From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70213: Info-mode side window fit-window-to-buffer issue Date: Sun, 07 Apr 2024 21:29:59 +0200 Message-ID: <877ch9ots8.fsf@gmx.net> References: <875xww2ncc.fsf@breatheoutbreathe.in> <86h6gg56vg.fsf@gnu.org> <871q7j3l4b.fsf@breatheoutbreathe.in> <87jzlbddt3.fsf@gmx.net> <87msq71n2a.fsf@breatheoutbreathe.in> <87sezzfo22.fsf@gmx.net> <87sezzs20t.fsf@breatheoutbreathe.in> <87y19qaff3.fsf@gmx.net> <877chaqtd4.fsf@breatheoutbreathe.in> <867chal4j1.fsf@mail.linkov.net> <5657beec-3caf-4e24-838a-111a9be63eb5@gmx.at> <87le5pt5eg.fsf@breatheoutbreathe.in> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21360"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , Eli Zaretskii , 70213@debbugs.gnu.org, Juri Linkov To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 07 21:31:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtYEQ-0005IY-B4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Apr 2024 21:31:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtYEG-0008WC-Em; Sun, 07 Apr 2024 15:31:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtYED-0008VE-77 for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 15:30:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtYEB-0002nq-Hw for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 15:30:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtYEI-0003a3-FB for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2024 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2024 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 70213-submit@debbugs.gnu.org id=B70213.171251822313544 (code B ref 70213); Sun, 07 Apr 2024 19:31:02 +0000 Original-Received: (at 70213) by debbugs.gnu.org; 7 Apr 2024 19:30:23 +0000 Original-Received: from localhost ([127.0.0.1]:44702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtYDf-0003WO-0f for submit@debbugs.gnu.org; Sun, 07 Apr 2024 15:30:23 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:56201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtYDd-0003W2-P3 for 70213@debbugs.gnu.org; Sun, 07 Apr 2024 15:30:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1712518203; x=1713123003; i=stephen.berman@gmx.net; bh=ic5ZYQQ67ZG1FARluNiScuDKD/GboRoSpxb68fm9F2E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=rARMpctu+g5VU5KqnryMzNBXF8U8VGeOb7jCVaQLVC+E/oxDD/ek3wb3c/jSIKpd Cr+8FEkxW0/3WSPJYblAkHInm8oaY+Ja6Q4VtsFG13TYMB/xgw50KIUXjNQG9xslT cFBCEN2sh92jDoJd5SToRoM+KuOseGg9DRp/+gLFCcUUFZHC/Wl5URnwnJQx83AJQ eYimqoL5d19+CjNlAb2dWY7r4T5saitmu3zJ2jsNtMvRPBIcBbodUN0TK6qXUxwUz IgnFuDP3j1rjmYkmXsPCoOkMcp7RA3CvQ54uc+qP6432O0U0rN2b8YJCB+Q74u7b9 evgaf3FyXmAnBp+ruw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.95.232]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4axq-1ru6BA3Wly-001kea; Sun, 07 Apr 2024 21:30:02 +0200 In-Reply-To: <87le5pt5eg.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 07 Apr 2024 10:53:00 -0700") X-Provags-ID: V03:K1:AIEnYxvGvzlXzPWO7+qWaS8mG6sgkKCrUk70TfiZXgEHztW9WJd N2SUvCGA2cE2pIrhk9+XAjiHdj1CxVOvSB+SXRiiYQCYHy8ybTWsYJhB+tpJE9xgtoJlqNW aISVhwUsnWXbr95kOUBBfrQGN3LgGV1QrbfbNRu2Nx+E4DEv2uv9OywEdYmdtJNBHqdUKe9 DlUak9TSMnZfK8vhVTlcw== UI-OutboundReport: notjunk:1;M01:P0:MizaiS1tF6E=;fgerINmb5dLlQtzK0mA+39DzBk4 MZ9vFsj8NSQi8CrplwybL9kZcEWoU2RWyPPOapjSSkR1ut64w/WTGn8kFxPwc8aw9c2IGXC5G hnB41MXIQr+JuoDQUDixq/ugYpyUSmbjcbfLu4EsBSuff0mQHj+WaCePycOmOSNh1KgiJV/nV 2LMYow4GSPtNn063+Kw3/qJVsTkWr3GHtzqdXx6NzREAbaNGtjbmknf8NUTCDcergb2rbJ8uS jzm4fSLNN9zFWobJGc5lM6oKxpPOP+dbJ/g3PDDvoidQOLHRB5O3VSMyrh30EzvERZs1oBsrj T/wp3B6NVDun+ZDW5AUeOr/+kRFFWLuoQyzihD0OKqRN4AvXyIQTMzzTpOZqbZv8WeBQCm3i1 S8nuTmHJyL/c0rOe77a8A5N2AEYiQN/wF3mcWcgTZ/VRoXICCrqwA2R1zClNThSJcNbvzFRZK aNdzc39353LvZB1SAaQPnHmRf6Sf50iWgnVOm89I7OdNhOONKSP88KgYltsBDI6SF2PxaCC0q ONK3iKn0/tYA0eyKrkUDTBJ6JGiLiGqkb7PnzJ+oIeCH9M/eM5T8Y9CjqlZjRA1oKnwT6ZkEm 5RtJHMwrJdcZi52Gpb2sjxDSUGNfggqUaIzcLsjZ3Y1evE9Jm+Ys3+IXR64Lb8csn3+mRV7Rp l06QkRt5azJ5X6lZ+iKqElpaguV8Kz6fhkrZWCUyjZDLG3brcLlYhKo7RnZtKeJ7F28XYeJl0 /GU2EEj+VpL1m5Z1kczhIZfuGugODIrBRI7f+ZkFl3DufCApgf03s0hAOzM19T0Nk9ojk58Q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282894 Archived-At: On Sun, 07 Apr 2024 10:53:00 -0700 Joseph Turner wrote: > martin rudalics writes: > >>>> In emacs -Q on master after Jan 6 patch, eval this: >>> >>> Maybe Martin could help to solve this problem (Cc-ed). >>> >>>> (progn >>>> (setq fit-window-to-buffer-horizontally t) >>>> >>>> (setq display-buffer-alist >>>> '(((derived-mode . Info-mode) >>>> display-buffer-in-side-window >>>> (side . right) >>>> (window-width . fit-window-to-buffer)) >>>> ((derived-mode . messages-buffer-mode) >>>> display-buffer-in-side-window >>>> (side . right) >>>> (window-width . fit-window-to-buffer))))) >> >> At the time we call 'fit-window-to-buffer' the buffer is empty so we >> show only 'window-min-width' columns. Don't we have 'body-function' for >> that? > > Thanks for the review! We have the same understanding of the issue. > > What do you mean by 'body-function'? > >>>> I would expect the *info* window to fit to the buffer contents >>>> when it first appears. The patch I sent earlier fixes this. >> >> That patch is >> >> Display-buffer-after-ensuring-it-contains-text.patch > >> IIUC. It already explains the problem in its name and does look good to >> me. > > Thanks for the review! Stephen, Juri, Eli, WDYT? I agree that your patch is an improvement when fit-window-to-buffer-horizontally is set to t. However, as I noted upthread, the resulting width of the right-side window is too small, unlike when using the same setting of display-buffer-alist with fit-window-to-buffer-horizontally set to nil, with which the setting of display-buffer-alist works just as well without your patch. So even with your patch, there remains a problem. Steve Berman