From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#70526: 29.2; package-vc-upgrade failed with error message "File is not under version control" Date: Wed, 24 Apr 2024 07:51:54 +0000 Message-ID: <877cgnkxk5.fsf@posteo.net> References: <87pluflvmq.fsf@posteo.net> <87bk5zl1ug.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70526 <70526@debbugs.gnu.org> To: "Yi Yue" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 24 09:53:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzXRN-0009tQ-BD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Apr 2024 09:53:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzXQv-00041W-RS; Wed, 24 Apr 2024 03:52:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzXQt-000418-P6 for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 03:52:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzXQt-00021o-Fi for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 03:52:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzXRA-0003qi-1f for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2024 03:53:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2024 07:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70526 X-GNU-PR-Package: emacs Original-Received: via spool by 70526-submit@debbugs.gnu.org id=B70526.171394514414398 (code B ref 70526); Wed, 24 Apr 2024 07:53:03 +0000 Original-Received: (at 70526) by debbugs.gnu.org; 24 Apr 2024 07:52:24 +0000 Original-Received: from localhost ([127.0.0.1]:57077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzXQU-0003k1-V8 for submit@debbugs.gnu.org; Wed, 24 Apr 2024 03:52:23 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:55987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzXQQ-0003iA-So for 70526@debbugs.gnu.org; Wed, 24 Apr 2024 03:52:20 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 99D5C240027 for <70526@debbugs.gnu.org>; Wed, 24 Apr 2024 09:51:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713945115; bh=XCFPBUWHV7bCA46tmh66lyNuHbTLAR2swskR0kj+/rQ=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=VsS5pIuY6MaMINVB+ZcC47q943dm5jszmuohNGGIdCJBnPMmynXZbj2LP5Xp/3JtI bHbGwtLZ2P1peof0svj6JWKOHporJ+I2ukz4PWLEN1pygJOuUTaEgqYGW/9Mkls7uM YyaEh1+EJ8Nu7yd5XhuoqI5hdlX+uPeWKrlQ1HH7y35yRwUI1CnpVB+BIq+95i5h9S 0fleSjS6oIjztJLL9ZGVJFZ49bOCMKOcWkcOK5IrkQa7iJ64H+sLjjvzJt3UbEq/jl Y54j3VUF/WY6cvipyZbKG/R2VYzaBAzWgz88t0AgCbKFm3UU0CoRvDH9zNHUABR6+H 9xiCGoaeO/aKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VPWQz1YDPz9rxK; Wed, 24 Apr 2024 09:51:55 +0200 (CEST) In-Reply-To: (Yi Yue's message of "Wed, 24 Apr 2024 16:02:42 +0900") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283908 Archived-At: "Yi Yue" writes: >> > >> > As you suggested earlier, maybe we need to modify vc.el, making the restriction looser? > >> If you can, try out the above patch and tell me if you end up having any >> issues, otherwise I don't think we need to adjust vc. > > Yes, it works as expected, thanks. But now it will create an > additional empty buffer named "{pkg}*", {pkg} is the name of pacakge. > So I suggest the following code: > > ------------------------------------------------------------------ > (with-demoted-errors "Failed to fetch: %S" > (require 'vc-dir) > (let ((vcbuf (vc-dir-prepare-status-buffer > (format " *vc-dir: %s*" pkg-dir) > pkg-dir (vc-responsible-backend pkg-dir)))) > (unwind-protect > (with-current-buffer vcbuf > (vc-pull)) > (kill-buffer vcbuf)))) > ------------------------------------------------------------------- > > Anyway, I think this buffer doesn't matter. Both are OK. As the buffer is hidden, I didn't see the need to clean it up. It can be re-used later on and might help with debugging. > Regards > > Yi Yue -- Philip Kaludercic on peregrine