unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
	iarchivedmywholelife@gmail.com, 70868@debbugs.gnu.org
Subject: bug#70868: 30.0.50;
Date: Tue, 14 May 2024 20:28:22 +0200	[thread overview]
Message-ID: <877cfwment.fsf@web.de> (raw)
In-Reply-To: <jwv5xviyarn.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 12 May 2024 17:39:46 -0400")

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> This said, I don't see the connection with printing small numbers as
> chars.  To print chars using the ELisp syntax you need `prin1-char`:
> AFAIK neither `prin1` nor `princ` work (at all).

Did I forget to attach the patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Further-tweak-pp-code-printing.patch --]
[-- Type: text/x-diff, Size: 1332 bytes --]

From e041c3a9d295f4c9946bcb693591eb47237cc4fe Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Sun, 12 May 2024 19:55:30 +0200
Subject: [PATCH] Further tweak pp code printing

This fixes an aspect of Bug#70868.

* lisp/emacs-lisp/pp.el (pp--insert-lisp): Print characters with
`prin1-char'.  In all other cases consistently print with `prin1'.
---
 lisp/emacs-lisp/pp.el | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/lisp/emacs-lisp/pp.el b/lisp/emacs-lisp/pp.el
index 47805d3dbde..1ca206cf5db 100644
--- a/lisp/emacs-lisp/pp.el
+++ b/lisp/emacs-lisp/pp.el
@@ -495,15 +495,12 @@ pp--insert-lisp
     ;; Print some of the smaller integers as characters, perhaps?
     (integer
      (if (<= ?0 sexp ?z)
-         (let ((print-integers-as-characters t))
-           (princ sexp (current-buffer)))
-       (princ sexp (current-buffer))))
+         (princ (prin1-char sexp) (current-buffer))
+       (prin1 sexp (current-buffer))))
     (string
      (let ((print-escape-newlines t))
        (prin1 sexp (current-buffer))))
-    (symbol
-     (prin1 sexp (current-buffer)))
-    (otherwise (princ sexp (current-buffer)))))
+    (otherwise (prin1 sexp (current-buffer)))))

 (defun pp--format-vector (sexp)
   (insert "[")
--
2.39.2


[-- Attachment #3: Type: text/plain, Size: 11 bytes --]



Michael.

  parent reply	other threads:[~2024-05-14 18:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 23:56 bug#70868: 30.0.50; pp--insert-lisp prints small integers as characters No Wayman
2024-05-11  0:10 ` No Wayman
2024-05-11  6:47   ` Eli Zaretskii
2024-05-11 10:58   ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11 11:09     ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11 12:08       ` Mattias Engdegård
2024-05-11 14:48         ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11 15:10           ` Mattias Engdegård
2024-05-11 11:32     ` Andreas Schwab
2024-05-11 10:54 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11 16:38   ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11 16:47     ` Eli Zaretskii
2024-05-11 18:26       ` bug#70868: 30.0.50; iarchivedmywholelife
2024-05-11 18:29         ` Eli Zaretskii
2024-05-11 18:33           ` Eli Zaretskii
2024-05-12 14:50             ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-12 15:06               ` Eli Zaretskii
2024-05-12 15:15                 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-12 15:42                   ` Eli Zaretskii
2024-05-12 18:11                     ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 10:51                       ` bug#70868: 30.0.50; pp--insert-lisp prints small integers as characters Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-12 21:39                     ` bug#70868: 30.0.50; Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 18:25                       ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 22:30                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 18:28                       ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-14 20:16                         ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cfwment.fsf@web.de \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70868@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).