From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions Date: Sat, 25 May 2024 17:45:21 -0700 Message-ID: <877cfhl7tq.fsf@breatheoutbreathe.in> References: <87edcrtegz.fsf@gmail.com> <87sf15rjyf.fsf@gmail.com> <8734t5yh49.fsf@posteo.net> <87edcp9p54.fsf@breatheoutbreathe.in> <878qzypbav.fsf@posteo.net> <87o78ul3fb.fsf@breatheoutbreathe.in> <87pltanuqf.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17599"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, 69528@debbugs.gnu.org, iarchivedmywholelife@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 26 02:47:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sB22a-0004HK-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 May 2024 02:47:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sB22J-0006Os-VT; Sat, 25 May 2024 20:46:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sB22I-0006Ok-Os for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 20:46:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sB22I-0006i7-H0 for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 20:46:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sB22P-0004KM-Rw for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 20:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 00:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69528 X-GNU-PR-Package: emacs Original-Received: via spool by 69528-submit@debbugs.gnu.org id=B69528.171668437513688 (code B ref 69528); Sun, 26 May 2024 00:47:01 +0000 Original-Received: (at 69528) by debbugs.gnu.org; 26 May 2024 00:46:15 +0000 Original-Received: from localhost ([127.0.0.1]:34253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB21e-0003Y4-LW for submit@debbugs.gnu.org; Sat, 25 May 2024 20:46:15 -0400 Original-Received: from out-175.mta1.migadu.com ([95.215.58.175]:39818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB21b-0003MV-QL for 69528@debbugs.gnu.org; Sat, 25 May 2024 20:46:12 -0400 X-Envelope-To: philipk@posteo.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1716684327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bVJg8EoN0jfdWR8ATaCw0eQCQ/68vG1EwwZ40rs3WcE=; b=IFKFrOmqOYIOP7M/d84DVkncxNNVYfoIfuqU7XPBu8oxB0muQ7wt9GaFfn0HxcAbYQCTMx nu25wUnUDRMV7mhQtUwjAMdhjWKVWnX9yshXzE2qK5axRYAlW1snrp6YWsL25fo+YAAC8i JDbnMXuhPTTDhRrETVTc4T2cnCatcQY= X-Envelope-To: 69528@debbugs.gnu.org X-Envelope-To: iarchivedmywholelife@gmail.com X-Envelope-To: eliz@gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <87pltanuqf.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 25 May 2024 08:47:36 +0000") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285917 Archived-At: Philip Kaludercic writes: > Joseph Turner writes: > >> Philip Kaludercic writes: >> >>> Joseph Turner writes: >>> >>>> Philip Kaludercic writes: >>>>> So in general, this patch might be appropriate? >>>>> >>>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loadde= fs-gen.el >>>>> index 581053f6304..42f386933dc 100644 >>>>> --- a/lisp/emacs-lisp/loaddefs-gen.el >>>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el >>>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file >>>>> ;; loaddefs for packages so that `syntax-ppss' later gives >>>>> ;; correct results. >>>>> (emacs-lisp-mode) >>>>> - (let ((version (lm-header "version")) >>>>> + (let ((version (or (lm-header "package-version") >>>>> + (lm-header "version"))) >>>>> package) >>>>> (when (and version >>>>> (setq version (ignore-errors (version-to-list v= ersion))) >>>>> >>>>> >>>> >>>> What about making `lm-version' handle the "package-version" header then >>>> using `lm-version' in loaddefs-generate--parse-file? See patches. >>> >>> My main concern was if we want to have Package-Version always override >>> Version, but if my patch modified loaddefs-gen, then I don't think there >>> is much of a difference if we change lisp-mnt instead (in terms of the >>> generality of the change). >> >> If it would be more appropriate, I can resubmit another patch with >> "Version" used preferentially over "Package-Version". > > No, I believe that would be wrong, at least going by these quotes from > the manual: > > (elisp) Simple Packages: > > The version number comes from the =E2=80=98Package-Version=E2=80=99 = header, if it > exists, or from the =E2=80=98Version=E2=80=99 header otherwise. One or= the other _must_ > be present. Here, the version number is 1.3. > > (elisp) Library Headers: > > =E2=80=98Package-Version=E2=80=99 > If =E2=80=98Version=E2=80=99 is not suitable for use by the packag= e manager, then a > package can define =E2=80=98Package-Version=E2=80=99; it will be u= sed instead. > This is handy if =E2=80=98Version=E2=80=99 is an RCS id or somethi= ng else that > cannot be parsed by =E2=80=98version-to-list=E2=80=99. > > So the patch is fine as it is. Thanks for double-checking.