From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jules Tamagnan Newsgroups: gmane.emacs.bugs Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Date: Mon, 24 Jun 2024 11:11:16 -0700 Message-ID: <877cee5hyz.fsf@gmail.com> References: <87a5jd8hqh.fsf@gmail.com> <877ceg9546.fsf@gmail.com> <874j9k8wpo.fsf@gmail.com> <87r0cn5n2s.fsf@gmail.com> <86zfrablxl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38920"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71716@debbugs.gnu.org, me@eshelyaron.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 20:13:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLoBn-0009rN-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 20:13:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLoBc-0005eN-3H; Mon, 24 Jun 2024 14:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLoBa-0005dp-8g for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 14:13:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLoBa-0006EI-0h for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 14:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLoBb-0001O0-54 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 14:13:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 18:13:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71716-submit@debbugs.gnu.org id=B71716.17192527485220 (code B ref 71716); Mon, 24 Jun 2024 18:13:03 +0000 Original-Received: (at 71716) by debbugs.gnu.org; 24 Jun 2024 18:12:28 +0000 Original-Received: from localhost ([127.0.0.1]:35336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLoB2-0001M8-99 for submit@debbugs.gnu.org; Mon, 24 Jun 2024 14:12:28 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:56646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLoB0-0001Lt-7a for 71716@debbugs.gnu.org; Mon, 24 Jun 2024 14:12:26 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1f480624d0fso36098595ad.1 for <71716@debbugs.gnu.org>; Mon, 24 Jun 2024 11:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719252679; x=1719857479; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jv6XmND2+x0HrkaZS3UzABnFz8DudO0SzYEKDkZFNn4=; b=e7RoLCU+KZ5cghsRVSOq1ngUqXY/ooN7kmIz67JaK/XNkgA6jStyShZWO/r1kP4Tb+ TxoMkuVwgHqN6GA/K3eS1TSa8QijHnxtmy1lGsF95vCq6OmXhBhJEuXWnX+AZ2uIkeqr 2V2oJ5yWx47hPypcuSWFGjsAFvu644MZl+SYh9WpR5lIqJvcF3YpCekayZpVa9QXW59S 3jc0eAmzbauCjexf+Xf26KuJkN/boF1cjvkuWREoZYtZ2Dz2dKEBd4fVZoJccgz3N+Qw KD4maFtEGSW/xP046n6SZChO/ZShRvSj2Qn4MOnNLYmLBh4vgxPuWl2fqGjPABQQTAXe xRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719252679; x=1719857479; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jv6XmND2+x0HrkaZS3UzABnFz8DudO0SzYEKDkZFNn4=; b=FWtcWlMcK0AQS2sSydhCHjwrTGwZ5ExWp6CMfLzMdQ/BkGfUHMxAh0wHQ1kaMcum2v enVvmQ9njve/5lI8Yf3S5eHlHTAv+8Gj8Qy8XHbumB9j4lCDHIj1iZyhQTUJphgjCTM1 gtM8UOUT8KJBhKX4Uq5jN1B3IEilDxE+a/G2rl55EkchIE1uzSOeWOkF+VYKjCvJbzRI HVYSL29xcXk/NMCES78+QEGy9dq1Lnbo7xYnYID9hhDUaE36EU7mmnMAznlAvndNBspi oqgC5wavr7WyKcEQUc2tiv4b6hzn1tk49pp/ZQ+cxFXJWLOzK0sODusX8b40OtkpI0LW CHPA== X-Gm-Message-State: AOJu0Yx3FI0O+oNfh4rMC/hjF4WrnHFGhiyjOnpnjLlDxuAhBGzjlCkr gUl6vKdf1V+G0wuIvtpH5JBZRrexVNnC2U5BX/LBOfKWbw7wPC9F X-Google-Smtp-Source: AGHT+IE+RdREhawzCbz9hUoWdJhKA36VrBEPKvdBbQt6WHxxDeO/kYRWsgpU0oxr9dkhk/amLEx0Vw== X-Received: by 2002:a17:903:41cd:b0:1f9:9768:ea88 with SMTP id d9443c01a7336-1fa24019ee7mr61439565ad.38.1719252678709; Mon, 24 Jun 2024 11:11:18 -0700 (PDT) Original-Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3205e8sm65822895ad.68.2024.06.24.11.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 11:11:18 -0700 (PDT) In-Reply-To: <86zfrablxl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Jun 2024 14:49:10 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287850 Archived-At: Hi Eli, Thank you for the review, I really appreciate it. Eli Zaretskii writes: >> Cc: 71716@debbugs.gnu.org >> From: Jules Tamagnan >> Date: Sun, 23 Jun 2024 15:08:43 -0700 >> >> +(defcustom completion-preview-context-variables '(char-script-table >> + forward-sexp-function >> + find-word-boundary-function-table >> + inhibit-field-text-motion) >> + "List of variables which can change the functionality of `forward-word' >> +or `forward-sexp'." >> + :type '(repeat (variable :tag "Variable" :value char-script-table)) >> + :version "30.1") > > I don't think we will install new features on the emacs-30 branch, so > this :version tag should be updated. And the previous one as well, I > guess. My latest patch for this change actually removed this variable entirely but I'll keep this in mind going forward. >> +(defun completion-preview--determine-substring (command string) >> + "A helper function to determine what parts of a STRING come before and >> +after the point when a certain COMMAND has been performed on that STRING" > > The first line of a doc string should be a single complete sentence. > That's because some help commands, like "M-x apropos", show only the > first line of the doc strings. Similarly, I've removed this function definition but will keep this in mind. Thank you. Best, Jules