From: Jules Tamagnan <jtamagnan@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71716@debbugs.gnu.org, me@eshelyaron.com
Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands
Date: Mon, 24 Jun 2024 11:11:16 -0700 [thread overview]
Message-ID: <877cee5hyz.fsf@gmail.com> (raw)
In-Reply-To: <86zfrablxl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Jun 2024 14:49:10 +0300")
Hi Eli,
Thank you for the review, I really appreciate it.
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 71716@debbugs.gnu.org
>> From: Jules Tamagnan <jtamagnan@gmail.com>
>> Date: Sun, 23 Jun 2024 15:08:43 -0700
>>
>> +(defcustom completion-preview-context-variables '(char-script-table
>> + forward-sexp-function
>> + find-word-boundary-function-table
>> + inhibit-field-text-motion)
>> + "List of variables which can change the functionality of `forward-word'
>> +or `forward-sexp'."
>> + :type '(repeat (variable :tag "Variable" :value char-script-table))
>> + :version "30.1")
>
> I don't think we will install new features on the emacs-30 branch, so
> this :version tag should be updated. And the previous one as well, I
> guess.
My latest patch for this change actually removed this variable entirely
but I'll keep this in mind going forward.
>> +(defun completion-preview--determine-substring (command string)
>> + "A helper function to determine what parts of a STRING come before and
>> +after the point when a certain COMMAND has been performed on that STRING"
>
> The first line of a doc string should be a single complete sentence.
> That's because some help commands, like "M-x apropos", show only the
> first line of the doc strings.
Similarly, I've removed this function definition but will keep this in
mind. Thank you.
Best,
Jules
next prev parent reply other threads:[~2024-06-24 18:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 9:11 bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Jules Tamagnan
2024-06-22 14:05 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 18:58 ` Jules Tamagnan
2024-06-22 22:00 ` Jules Tamagnan
2024-06-23 8:00 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-23 22:08 ` Jules Tamagnan
2024-06-24 0:45 ` Jules Tamagnan
2024-06-24 11:49 ` Eli Zaretskii
2024-06-24 18:11 ` Jules Tamagnan [this message]
2024-06-24 12:43 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-24 17:16 ` Jules Tamagnan
2024-06-26 11:41 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-28 5:49 ` Jules Tamagnan
2024-06-28 15:00 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-27 6:33 ` Juri Linkov
2024-06-27 18:31 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cee5hyz.fsf@gmail.com \
--to=jtamagnan@gmail.com \
--cc=71716@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).