From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#71554: 29.3; eshell-command async buffer behavior Date: Fri, 05 Jul 2024 18:44:39 +0000 Message-ID: <877cdz7k6g.fsf@posteo.net> References: <87frtfpqyn.fsf@librehacker.com> <87ikyb8igc.fsf@posteo.net> <86tthvwdxp.fsf@gnu.org> <87ed8z8duo.fsf@posteo.net> <87a5jm94b6.fsf@posteo.net> <874j9ogjfo.fsf@posteo.net> <3ed3832f-e874-ab89-52c3-c0c32650cb33@gmail.com> <86o77qbjv9.fsf@gnu.org> <87r0c87a48.fsf@posteo.net> <86plrs75my.fsf@gnu.org> <87r0c8nyp4.fsf@posteo.net> <865xtk6qkl.fsf@gnu.org> <87le2gyqq8.fsf@posteo.net> <87h6d3zz52.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11729"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , christopher@librehacker.com, Eli Zaretskii , 71554@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 20:42:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPnsz-0002ou-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 20:42:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPnsh-00065M-97; Fri, 05 Jul 2024 14:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPnse-00064z-2R for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 14:42:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPnsd-0002i8-QW for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 14:41:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPnsg-0007RU-1G for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 14:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71554 X-GNU-PR-Package: emacs Original-Received: via spool by 71554-submit@debbugs.gnu.org id=B71554.172020490928585 (code B ref 71554); Fri, 05 Jul 2024 18:42:01 +0000 Original-Received: (at 71554) by debbugs.gnu.org; 5 Jul 2024 18:41:49 +0000 Original-Received: from localhost ([127.0.0.1]:45008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPnsS-0007Qz-Sd for submit@debbugs.gnu.org; Fri, 05 Jul 2024 14:41:49 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:47591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPnsR-0007Qh-N2 for 71554@debbugs.gnu.org; Fri, 05 Jul 2024 14:41:48 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E13C3240027 for <71554@debbugs.gnu.org>; Fri, 5 Jul 2024 20:41:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1720204898; bh=0BrKj4FDAChyUFCmttx/hXrEYqJ7jqa1lrOvCmhiBgc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Autocrypt:OpenPGP:From; b=rXnbA2m7no0M6h0TDWUKnzDUkjySx3U6APrZxT7Uqh5guQR+MTz+fqpOvT1KKpslp HIraGUK352H2Y5Yjhox+f9IrT3uFeFFv9Lc13fBwIzVpJQWagHZAbRd0XvdizQz5Z9 WZQZNDuoDOCZa46cS8upcYpA5hLqjrRkYqubOPd21Z0dz6vbbFQXr3ltdz1MN4eHas 1qtSLzIsskZOnH5elg6FLeZ+WghJszsnidQu+6RrasRi5RR7EUPTqyhnh9cx+BriXW 6CnODHVWivKcrjSffeAUNH6wE7POb95M+Z/94UsA4HC0d/QTW+2DGlZ6hleOCRwx37 tufYC1U6SfWPQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WG2RN4MG6z6tsB; Fri, 5 Jul 2024 20:41:36 +0200 (CEST) In-Reply-To: (Jim Porter's message of "Fri, 5 Jul 2024 10:41:20 -0700") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288433 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jim Porter writes: > On 7/5/2024 7:34 AM, Thierry Volpiatto wrote: >> Here the patch modified (only changed default value, a typo and the >> commit message). > > Thanks. One question about this before I merge: is the 'cl-loop' part > necessary? I glossed over that part when reviewing the patch > previously, but thinking about it more (and consulting 'shell-command' > and 'shell-command--same-buffer-confirm'), I'm not sure we need it. > > My understanding is that this would prompt the user if there were a > buffer named "*Eshell Async Command Output*" (good), but also if there > were a buffer named "*Eshell Async Command Output*<2>" (possibly > unnecessary). Why? If we remove the cl-loop, we will have only: (if (buffer-live-p (get-buffer "*Eshell Async Command Output*")) (do something according to eshell-command-async-buffer)) which will return nil and (rename-buffer buf "*Eshell Async Command Output*" nil) will run inconditionally without asking anything while the process in "*Eshell Async Command Output*<2>" is still (maybe) running. Did I miss something? > I can see the reasoning for doing this for the 'confirm-kill-process' > setting (it tries to keep the number of async Eshell commands to 1), > but less so for the other settings. I don't think it's useful for > 'confirm-new-buffer' or 'confirm-rename-buffer'. Not useful for 'confirm-rename-buffer' but useful for 'confirm-new-buffer' no? > Given the above, and that 'shell-command' doesn't do this, maybe > Eshell shouldn't either? As long as people don't delete their buffers manually until everything is finished, yes we should behave as 'shell-command'. We can remove the cl-loop if you want, anyway we will see if somebody report a problem with this. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmaIPxcTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk8ESDAC5b9v+exPHMlyJ5Gs4MyTMn4ZHyakJ OQuiuUMxEmKxuHIAYzhh0GY23sDcPmuIREYAGA/oHjdljAlSYzE/ujxQj96UXXT1 yfxiGpq8ywt7GprdA6abAJm4ytNeiHpf9mUDBmIOkQb3z5g/bp3WsHI5wbcA4nJH uofC6FDoiz+f2S94FGv7dn2ypo211Srk0gYT2GwVmcfNAIG3E/avfvPQVQgVVsvm BxccqtsMWsm33dNy8z/w+FKodByUK5KnDymGKuUeY5/J1DWSL7l0Ou5bDsvyecFD yA4LBUfVw4wq94Uls0JIrAAIvXwXuKrKnOs2VDz4f2FjB9S0O5hISEpTsG0ctrC8 62mK83LJEuGa5TeCjdigwvdcYXksG1xOPVRzmIT4F9Yqsc6/E5T5BsAoZ0F9VPLL XYducK7rq8ld2PUqVQgoAGIM8PKix6O2WBXCswvo117FW2mcQi2jqldFgWsDqfQT DdYiQVILzQl0Y2OaDih4f+5Vj5mUQ/j6lGk= =LLbY -----END PGP SIGNATURE----- --=-=-=--