From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#72456: [PATCH] rcirc: Fix startup channels triggering flood protection Date: Sun, 04 Aug 2024 14:55:58 +0000 Message-ID: <877ccwz69t.fsf@posteo.net> References: <87y15dkvhw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72456@debbugs.gnu.org To: Thuna Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 16:56:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sacfH-0006Lh-AI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 16:56:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sacf5-0000jU-Mu; Sun, 04 Aug 2024 10:56:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sacf4-0000iu-6A for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 10:56:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sacf3-0004gQ-Sw for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 10:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wHwZx63yiqtjEmZMYwSUSOfji4a8noSC1XrZtKC4w4M=; b=jngSCXbXLtCiNVfzWEriGKEdV29ffmRLqPjP14oUu8VrxUPZeofIBONV2Lr9uI8lPUvgVsZMskfcKJqu+Qu0xV/mG7/rVim4aAvuk66p7lBHO1FxRejFHgNb4a3WcCwipI043T5SUSBaSsaiR07UQ9omAOPU3DUxylzAKxjfYhC42rn0BeUzZ9iuqvEaV/IYqhVKY3z0tjzz0WISJkPXKejre0H79jM4voTpu2c7DMiSA3TVhtZqZm3coUg4Scm2/NR2uCUNvRxyogmIPuq+StAcPG2Qlefzw+d9DUUj+z2Sx0Lo2oIvFuAFAvTzv+2+HwRrm0vU7sf9ORC/Hgc4Aw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sacfO-0002Jk-VV for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 10:57:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72456-submit@debbugs.gnu.org id=B72456.17227833908791 (code B ref 72456); Sun, 04 Aug 2024 14:57:02 +0000 Original-Received: (at 72456) by debbugs.gnu.org; 4 Aug 2024 14:56:30 +0000 Original-Received: from localhost ([127.0.0.1]:56960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saces-0002Hi-99 for submit@debbugs.gnu.org; Sun, 04 Aug 2024 10:56:30 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:54281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saceq-0002HN-8f for 72456@debbugs.gnu.org; Sun, 04 Aug 2024 10:56:28 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CFF29240103 for <72456@debbugs.gnu.org>; Sun, 4 Aug 2024 16:55:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722783360; bh=6Q7jV4xLkthsPfB36YzfOmJ5ELV1T5hw+R4mGNL5DcU=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=T4rS10F+wJ7rSa7mIgP69A8hvQ51CUR/pkCeRU19Gu6sJDWsXv8/MRncNb9QulvNO osnr+P8QVduLoj6wQWMiv3hJTjjdW3pHIo6Ami/A4UnHzN8tqJSGDrDYcwdUP5ta+R 72bD37XvfeOk6t8YHTVS+nCnUqicRQqUchOMOmEYbQq44GzD02ndwyALba4KgKDy9U 8BM7f/IpOy5eBuZkX7lrdCa+l0JHcZIkk+qNJgOpRkJNNy2g49yOGHFM6qYgSfl64T ittLe5M7jfNrsrYAlw8RRYJ2yRtUzyYpt4Ju2r53B5DSfl4AqyWzLDWxtMnz0R5HRZ yPIZT8rt+VRJw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WcN1C0b9Nz6tvJ; Sun, 4 Aug 2024 16:55:59 +0200 (CEST) In-Reply-To: <87y15dkvhw.fsf@gmail.com> (Thuna's message of "Sun, 04 Aug 2024 02:00:11 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289759 Archived-At: Thuna writes: > If too many channels are set up to be joined on startup, all of their > JOIN messages are sent at once, possibly triggering the flood protection > of the server and causing the link to be forcefully severed. (In libera > I hit this limit with 12 channels - not a lot, all things considered.) > > This patch mitigates this by sending a single JOIN message with all the > channels joined with ",". > > This has a flaw, which is mentioned in the patch in a FIXME, in that if > the total length of the channels exceeds the maximum length of a message > then the message will likely split and break. While checking for it > while joining the channel names is a possibility, it's probably better > if we split command messages more elegantly in the first place. I think we should fix that before applying the change, as I cannot imagine that the error message in that case will be in any way helpful. > From 9c205cfe46679f17f5e8cf8b4c2999e50eb97adb Mon Sep 17 00:00:00 2001 > From: Thuna > Date: Fri, 22 Mar 2024 14:58:03 +0100 > Subject: [PATCH] [WIP] rcirc fix startup channels flooding the server > > --- > lisp/net/rcirc.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index 6e71085808a..a3912ac4047 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -2265,9 +2265,9 @@ rcirc-join-channels > "Join CHANNELS. > PROCESS is the process object for the current connection." > (save-window-excursion > - (dolist (channel channels) > - (with-rcirc-process-buffer process > - (rcirc-cmd-join channel process))))) > + (with-rcirc-process-buffer process > + ;; FIXME: Handle the situation where the full message is too long > + (rcirc-cmd-join (string-join channels ",") process)))) > > ;;; nick management > (defvar rcirc-nick-prefix-chars '(?~ ?& ?@ ?% ?+) -- Philip Kaludercic on peregrine