From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72323: 31.0.50; line-move unconditionally resets vscroll to 0 Date: Sun, 18 Aug 2024 10:38:29 -0700 Message-ID: <877ccd3f56.fsf@stebalien.com> References: <87zfq2hg4n.fsf@stebalien.com> <86ikwq1z92.fsf@gnu.org> <87v80qha04.fsf@stebalien.com> <86cymy15n2.fsf@gnu.org> <877cd59t76.fsf@stebalien.com> <86jzh4zc2w.fsf@gnu.org> Reply-To: Steven Allen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26321"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 72323@debbugs.gnu.org, storm@cua.dk To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 18 19:39:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfjsN-0006g4-H7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Aug 2024 19:39:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfjsC-0004Tq-8X; Sun, 18 Aug 2024 13:39:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfjs9-0004Td-Rf for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 13:39:22 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfjs9-0004lc-Iz for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 13:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=SMuUIpYPhyvcwbfrhlGmAUes8MP2qxiQbHVhn5O2s8g=; b=j55Ge1//XaNCw3RaeVl8+6zohCyeRw07GQ2Eco+goxRJxs/yZ2fs2/hpusaWQ8mxNXMCZPEwBhjGeoLLRU4QxKOOA6t144Z9SI8JHO5lcVwDyffcFA/93NhhV9mObATRoXG4goUbAsXUyR5qYlCIRiSyKUJv5FDfTUcPlo/hcs2dYTE6SfTVxpyhcoTaVQl63EpK8eD///vBWtQZ5p4hr7xYXSs1zCnX/SBz/r3k+/wvYSa2bMPCSNZqdLgKqzL8JA1HPHHOmB9Y/DcvKBN5XXF7KEzJK8UuVcN7Mk+HXHAiRnRpbmBb/5Vmjj/J272+NadyR/6VeIW2j7CPbuZMpA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfjso-0005On-0i for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2024 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72323 X-GNU-PR-Package: emacs Original-Received: via spool by 72323-submit@debbugs.gnu.org id=B72323.172400276120703 (code B ref 72323); Sun, 18 Aug 2024 17:40:01 +0000 Original-Received: (at 72323) by debbugs.gnu.org; 18 Aug 2024 17:39:21 +0000 Original-Received: from localhost ([127.0.0.1]:56741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjs9-0005Nr-3X for submit@debbugs.gnu.org; Sun, 18 Aug 2024 13:39:21 -0400 Original-Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:53851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjs5-0005NV-IF for 72323@debbugs.gnu.org; Sun, 18 Aug 2024 13:39:19 -0400 Original-Received: from phl-compute-05.internal (phl-compute-05.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id D031D114ABBB; Sun, 18 Aug 2024 13:38:31 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sun, 18 Aug 2024 13:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1724002711; x= 1724089111; bh=SMuUIpYPhyvcwbfrhlGmAUes8MP2qxiQbHVhn5O2s8g=; b=m d9tS94pobO/1s2IgAlJ6R/1sgy6ZPx0oSjksSL6/Htr62uF868Rc5z6C6HjiNHSc hdxbXeNZ2815GZ9CaxewE1qANcIlS+HzlF7LCGt4u732QuWzKGeZSSf5WNaKDN5K 8aurUmPQYz6sHzGcJeOwWRrdaT73KNqhyj4UydNtKY1Eeba7B5ER6A9TEyD5tm4a aollY/ldRJjfHmaIrQR26roQRK1lpWPrmpPgV3qTJs/LrPC27ijhAhAE5OH3D9GQ laA439gSQY2MzfWLBFz4uCn36Ebd7sitEcdwJA5D29UOEvm316uaDj7I5UyVM6Rq VqprrVt2zj6Ujj4xoF7LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1724002711; x=1724089111; bh=SMuUIpYPhyvcwbfrhlGmAUes8MP2 qxiQbHVhn5O2s8g=; b=IySGU5VJxozYHAlFTEOP6ZlwO9gAjoGzgX8kjeM2CYSv aWl1JBrolSJl0tcg9n2ck6tnvIs1Jwe4uvGpvWndYsCcelt6TjNB9s26Gi/ipfZi mHKtv46gKjn06onhLi3+XTq5nQ/Vp9gGYDe0XC46z8LqTt8WcmxzP7ejABT1mUIX SUIHVXG9xnJOKr+he+huDEDbCUqdBF+tKeLzYSeyXFjO3FmO3ELLPd8URv10io/g iTy8CNoudhkcNuqUqCf7H+/HtaDkkOqOuyHSWqBqhrjpWLd4UMEwrbFsYUsrfHJM 3CAN4VHwadrhr1+KUYGNjokja5EC+11VXmSwMfmtEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudduvddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttden ucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivg hnrdgtohhmqeenucggtffrrghtthgvrhhnpedvkeehkeegleehheeggfduleektefhhffg ueffteekgedtvdefuddutddtjeejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgs pghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiise hgnhhurdhorhhgpdhrtghpthhtoheplhhurghnghhruhhoseihrghhohhordgtohhmpdhr tghpthhtohepjedvfedvfeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhope hsthhorhhmsegtuhgrrdgukh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Aug 2024 13:38:30 -0400 (EDT) In-Reply-To: <86jzh4zc2w.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290338 Archived-At: Eli Zaretskii writes: >> From: Steven Allen >> Cc: 72323@debbugs.gnu.org, storm@cua.dk >> Date: Sun, 28 Jul 2024 13:07:09 -0700 >> >> Eli Zaretskii writes: >> >> > vscroll is not just about scrolling the window. It is basically a >> > vertical offset from the screen line that shows window-start to the >> > top-most pixel shown in the window. It is meant to enable to see the >> > tall screen line at window-start in its entirety. Once point moves >> > off that screen line, vscroll is no longer pertinent, since the >> > important line, for which vscroll has been determined, has changed. >> > For example, imagine that the line into which point moves cannot be >> > displayed in its entirety with this vscroll, because it starts at a >> > different vertical coordinate (so its lower part could be below the >> > window bottom). >> >> No? E.g., if I have half a line (or half an image) visible and move my >> point off that line, I wouldn't expect that line to suddenly scroll out >> of view _unless_ the entire screen needs to scroll because the >> text/image is larger than the entire screen. > > It depends on the details of the line from which you move cursor and > the one into which you move. For example, if the former takes up > almost the entire window, then moving into the next one could cause > that next line to be only partially visible, and that is unacceptable > for the Emacs redisplay. In that case I completely agree. If point moves to a partially displayed line, vscroll needs to be adjusted and/or reset. > Once again: the vscroll value is pertinent only for the screen line > for which it was computed, because the way it is computed uses the > metrics of that line. Once you move to another line, the value is no > longer pertinent. Let's be precise about "move to another line": - When window-start changes, vscroll becomes invalid because the lines at the top of the screen (to which vscroll applies) has changed. I agree that it must be reset in this case. - When point is moved up and down in such a way that window-start isn't changed, vscroll is still perfectly valid as the top line in the window hasn't changed. vscroll is relative to the top line, not point. > Emacs supports smooth scrolling only within a single screen line, and > that uses vscroll. That's the original design intent of vscroll. > Smooth scrolling between lines is not really supported. > pixel-scrolling attempts to solve that, and does it well, but it does > have some problematic corners. Those corners need to be solved inside > pixel-scroll code. Honestly, scrolling between lines is working perfectly. I'm not running into issues when scrolling, I'm running into issues when changing lines after partially scrolling a line.