From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#68183: 28.3; vc-dir fails when I have a certain branch checked out Date: Tue, 20 Aug 2024 08:15:37 +0200 Message-ID: <877ccbhg8m.fsf@gmail.com> References: <8734vici68.fsf@tromey.com> <83y1da17zw.fsf@gnu.org> <87y1dab03x.fsf@tromey.com> <87h6jun400.fsf@gmail.com> <878r3q2jfx.fsf@gmail.com> <877cj6izv7.fsf@gmail.com> <87zfuyrrfz.fsf@gmail.com> <283baeb9-d427-45a3-92d5-5e6c095b87ad@gutov.dev> <87ttl43f2x.fsf@gmail.com> <06a946b4-b06a-4e10-93d5-b6d6b8bd9fcf@gutov.dev> <87h6bwqujo.fsf@gmail.com> <9446a412-5221-4466-b7e8-937957fd82f2@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68183@debbugs.gnu.org, Tom Tromey , Sean Whitton , Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 20 08:17:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgIBe-0007OC-Cc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Aug 2024 08:17:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgIBJ-0006Bb-HM; Tue, 20 Aug 2024 02:17:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgIBE-00069g-EC for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:17:21 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgIBD-0002X7-RG for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:17:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=jnnSegbFGPFclSA3A2H+HQp2yHnUdhcMuatMfyWElx8=; b=JZ1PLM/1i+LEuk9b4RJmXzBdCSTwWA8kK/pbGzh3cN6wTGiXIIgG/LV8AjUe2bAPDLu7bBphWgSPaTBSZEcJzIlj2qulFUYgh3eczM1ZnG2Lm/QDXlZ0rwognJ4Z+oM40ZNyR27ShBw5vHYsbOAsm7fQpzdDiSzMGZOeOpfmXzm1TzFP1s2WbX1wEJM8cXKgWmNkZmWnzLxwR7+5fLCVuL6iMUvN9aZ3Hm8gxb9RYYep3/QMzcepK5WikeJuowSwho9sF+Ybpc/8qe0dx7TXGVKnnDlO53Xs6XyVJK4d9xP2E4a8XuWbNuiXwLi/OgnSivc7sjHnXZbA9R1Nq4CwsA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgIBu-0007AM-9P for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2024 06:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68183 X-GNU-PR-Package: emacs Original-Received: via spool by 68183-submit@debbugs.gnu.org id=B68183.172413465027499 (code B ref 68183); Tue, 20 Aug 2024 06:18:02 +0000 Original-Received: (at 68183) by debbugs.gnu.org; 20 Aug 2024 06:17:30 +0000 Original-Received: from localhost ([127.0.0.1]:59682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgIBO-00079T-9L for submit@debbugs.gnu.org; Tue, 20 Aug 2024 02:17:30 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:60498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgIBL-00079E-TL for 68183@debbugs.gnu.org; Tue, 20 Aug 2024 02:17:28 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42ab880b73eso2310875e9.0 for <68183@debbugs.gnu.org>; Mon, 19 Aug 2024 23:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724134539; x=1724739339; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jnnSegbFGPFclSA3A2H+HQp2yHnUdhcMuatMfyWElx8=; b=eC0sjIWTH6YoDS+OVwLr0PfvYW7QndJGgRYCMfNGxL/zRhOKdPPmCYTfiu/CjOxCI0 Hvh01iqw13zkrcUq7MHcwHyJL8THfNKY1Gy+pkzkdlFlZTQOVdNPAorPLwuAglTDFYTA GvvmqV6dPvxblyQmmCax364LxiGB3+NjjfUBg2n7lADSiV2HIaScA+nKh6NQX0j+29bP nNEwSMDXDWADQS6qynsmg979BQK23qv//4r3U46VQ1H9YiWAPeEv5pABrGriLOxpPbjo nPRHjj/j+MLNOTEFsczlrfIDFwiaqB0qxGRCPQlMA34J8+faYYNoDbhC0sM9sjgdgqlA +j2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724134539; x=1724739339; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jnnSegbFGPFclSA3A2H+HQp2yHnUdhcMuatMfyWElx8=; b=ESWX8dYfAnNlQcbl8LLGjVTLPLt4oqH5m66SPhzpyXEGVmlvI+7bCdxAa01dWiKXQv paOb5/mzcuzV9F0g3wGozf60tBR12VCkYs+eSxh6k5Z52k7oIuJEJucUFAUveOKdBCoM xi5dtqSeJWtRbSCbGvY4jTgtVxWAcf18dUNq4DbS7Wnu0sMOGL8ynft8Ld4d/hAvRQV+ JNNiiJqW2xE2oF00t+62J5ZnBNeOPXqQTiCrasiUjzIJDEnuFJLUi1/monThBZAHd0dF iC3cXZimNJi6OZDdDNgfX6esZV7QLuY/Iqq28SLT5P5d5tzwiAvbuvZdh9g9q8RMLf/Q jmtw== X-Gm-Message-State: AOJu0YygRvUsNB81E8VwVBwGY4CDBse3DPJmLmhRbjp2FeoQgIEv0bFr AFal6VQrXrV9mEN9MYoFAEjXWgZX1uYTXvaLaAyeGQOIAUeqoQ9B X-Google-Smtp-Source: AGHT+IFcp1/DkTBPllVPjY9QRYr0CLncwZfHYrI+gDNqm0pu36ZXrqjgosNd3RYn6DFHO34SW4MrxQ== X-Received: by 2002:a05:600c:4712:b0:426:6c70:dd9c with SMTP id 5b1f17b1804b1-429ed7f9179mr96011015e9.31.1724134539027; Mon, 19 Aug 2024 23:15:39 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed65072asm130031185e9.13.2024.08.19.23.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 23:15:38 -0700 (PDT) In-Reply-To: <9446a412-5221-4466-b7e8-937957fd82f2@gutov.dev> (Dmitry Gutov's message of "Tue, 13 Aug 2024 04:32:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290424 Archived-At: Dmitry Gutov writes: > Hi Kevin, > > On 07/08/2024 17:25, K=C3=A9vin Le Gouguec wrote: >> Heya, >> Have spent cycles on this on-and-off these past few months; finally have >> something worth discussing, I think =F0=9F=A4=9E >> To recap where we stand, AFAIU: the reported vc-dir bug has been fixed >> (in time for the emacs-30 branch), but the changes could feel intrusive, >> since a new vc-dir header was added ("Tracking") that some users may not >> care for. > > I haven't looked at the patch in detail, but FWIW the new header feels li= ke a minor enough detail to not be annoying (or even noticeable) when you d= on't want it, but it's good to have when you do need that info. > > This is my impression after having that feature around for a few months s= ince it's been introduced anyway. > > Just a data point. Not to imply that the code couldn't be improved, or th= at the new option can't be useful. Thanks for weighing in. Since I am not a frequent vc-dir user, my disposition would then be to avoid committing to sophisticated user options until there is demand for it. So, at this stage, ISTM: * We could apply [patch 1] (new tests) on emacs-30. * I should draft a NEWS entry for the new header, for emacs-30. * We could apply [patch 2] (refactoring; modulo the considerations re. vc-git--cmds-in-progress discussed with Sean) on master, if we feel like it makes vc-git-dir-extra-headers easier to work with. [patch 1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68183;filename= =3D0001-Test-more-vc-dir-scenarios-with-Git-bug-68183.patch;msg=3D41;att=3D1 [patch 2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68183;filename= =3D0002-Split-vc-git-dir-extra-headers-into-more-manageable-.patch;msg=3D41= ;att=3D2