From: Sean Whitton <spwhitton@spwhitton.name>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73387@debbugs.gnu.org, juri@linkov.net, monnier@iro.umontreal.ca,
dgutov@yandex.ru
Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
Date: Thu, 03 Oct 2024 08:50:37 +0800 [thread overview]
Message-ID: <877caq3t7m.fsf@melete.silentflame.com> (raw)
In-Reply-To: <86jzer0yd9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Oct 2024 10:15:14 +0300")
Hello,
On Wed 02 Oct 2024 at 10:15am +03, Eli Zaretskii wrote:
> This doesn't really address the issue, IMO.
>
> The main problem I have here is with the "all" part of the first
> sentence, which is then contradicted by the second. Also, in other
> places, you describe the behavior when region is active, but not when
> it isn't.
>
> Here's what I would suggest to say in the manual:
>
> @item C-c @key{RET} k
> Delete diff hunks other than the current one. If the region is
> active, this command deletes the hunks overlapped by the region;
> otherwise it deletes all the hunks other than the current hunk. Do
> @emph{not} invoke this command in a narrowed buffer, as that could
> produce unexpected results.
Okay, I've rewritten based on this, though I haven't included the
imprecation, because invoking it in a narrowed buffer could never
produce unexpected results -- the function will always do nothing.
> And this is for the command's doc string:
>
> (defun diff-delete-other-hunks (&optional beg end)
> "Delete diff hunks other than the current one.
> Interactively, if the region is active, delete all the hunks which
> the region overlaps; otherwise delete all the hunks except the
> current one.
> When calling from Lisp, pass BEG and END as the bounds of region in
> which to delete diff hunks; BEG and END omitted or nil means to
> delete all the hunks but the one which contains point.
Done, thanks.
--
Sean Whitton
next prev parent reply other threads:[~2024-10-03 0:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 16:08 bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Sean Whitton
2024-09-22 12:46 ` Sean Whitton
2024-09-23 22:41 ` Dmitry Gutov
2024-09-23 22:41 ` Dmitry Gutov
2024-09-24 6:32 ` Juri Linkov
2024-09-24 15:54 ` Sean Whitton
2024-09-24 17:36 ` Dmitry Gutov
2024-09-25 6:34 ` Sean Whitton
2024-09-25 23:46 ` Dmitry Gutov
2024-09-27 11:55 ` Sean Whitton
2024-09-27 19:13 ` Dmitry Gutov
2024-09-29 23:46 ` Sean Whitton
2024-09-30 0:27 ` Dmitry Gutov
2024-09-30 9:38 ` Sean Whitton
2024-09-30 10:11 ` Dmitry Gutov
2024-09-30 13:10 ` Sean Whitton
2024-09-30 13:25 ` Sean Whitton
2024-09-30 14:15 ` Eli Zaretskii
2024-10-01 0:50 ` Sean Whitton
2024-10-01 15:51 ` Eli Zaretskii
2024-10-01 19:13 ` Dmitry Gutov
2024-10-02 6:17 ` Eli Zaretskii
2024-10-02 1:26 ` Sean Whitton
2024-10-02 7:15 ` Eli Zaretskii
2024-10-03 0:50 ` Sean Whitton [this message]
2024-10-03 6:33 ` Eli Zaretskii
2024-10-03 7:06 ` Sean Whitton
2024-10-03 11:07 ` Eli Zaretskii
2024-10-03 11:15 ` Dmitry Gutov
2024-10-03 11:36 ` Sean Whitton
2024-10-03 12:15 ` Eli Zaretskii
2024-10-04 1:41 ` Sean Whitton
2024-10-01 0:27 ` Dmitry Gutov
2024-10-01 0:57 ` Sean Whitton
2024-10-01 0:39 ` Dmitry Gutov
2024-10-01 1:01 ` Sean Whitton
2024-10-01 1:15 ` Dmitry Gutov
2024-10-01 1:40 ` Sean Whitton
2024-10-01 1:57 ` Dmitry Gutov
2024-10-01 2:41 ` Sean Whitton
2024-10-01 13:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-02 1:24 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877caq3t7m.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=73387@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).