From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Sebasti=C3=A1n_?= =?UTF-8?Q?Mon=C3=ADa?= Newsgroups: gmane.emacs.bugs Subject: bug#73133: 29.2; EWW fails to render some webpages Date: Wed, 23 Oct 2024 23:32:37 -0400 Message-ID: <877c9ygoq2.fsf@sebasmonia.com> References: <86613F3D-B7C8-4498-B435-7AAF342264C2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , Eli Zaretskii , 73133@debbugs.gnu.org, ganimard@tuta.io To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 24 05:34:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3oc1-0008rJ-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Oct 2024 05:34:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3obO-0000tT-FR; Wed, 23 Oct 2024 23:33:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3obN-0000t2-1J for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 23:33:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3obM-0000IE-KL for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 23:33:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=XTVa13tR+JrQP+Nm0IcLHQ01kkxRegQGhNTBHJmwh94=; b=sDvYBRojKtOLyKpHLCtImfP94pw6O1pjTKd7NP43Ev72PnVbj1ZQuRUG0rR1pImJBrkc+ImmfnKsAdT+e/t571pFzWbhocT6g2qxCd6fAuEGBQ9SxVDBrPQsknKsYP8YZ/3P9hkSrZPOS2hwJ5ixn/DQXW75nOhaOSOzXH9xSr7h+Jn+c8dltl+AQ5e8IroeiWUtraw4+mDOjsGbspU6urhHvJ6kG25mw9O1+ms3AYM0bhB6u9NrEkigWftGi/pfoR8s4qdZnEu7XPr77/5VE49hH+m3G8mz5Kbmo7FrEm8teBasl0+2KshhMgxX8tM8ANstH7yIzrUsiBdeHjNKFA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3obp-0000uk-LI for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2024 23:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Sebasti=C3=A1n_?= =?UTF-8?Q?Mon=C3=ADa?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2024 03:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73133 X-GNU-PR-Package: emacs Original-Received: via spool by 73133-submit@debbugs.gnu.org id=B73133.17297408003451 (code B ref 73133); Thu, 24 Oct 2024 03:34:01 +0000 Original-Received: (at 73133) by debbugs.gnu.org; 24 Oct 2024 03:33:20 +0000 Original-Received: from localhost ([127.0.0.1]:33118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ob9-0000ta-No for submit@debbugs.gnu.org; Wed, 23 Oct 2024 23:33:20 -0400 Original-Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]:50569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ob4-0000t9-Su for 73133@debbugs.gnu.org; Wed, 23 Oct 2024 23:33:18 -0400 Original-Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 520921380279; Wed, 23 Oct 2024 23:32:39 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 23 Oct 2024 23:32:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sebasmonia.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1729740759; x=1729827159; bh=XTVa13tR+JrQP+Nm0IcLHQ01kkxRegQG hNTBHJmwh94=; b=TOr3iKIs9qlg7xqZ4H4uOBYPXLF1XKOLSyjbu0l4mNrSlNZf bY45gjj2Vb8bpj6QWwoRffvXMkjxoGeforIaAq11RsBy9SxjdfFmvuIfFLaXL3sr m+92KiXeya6/yqGnC8zX97jcUz3tS/Dql2ilxTFT6A16RXaUxICXLYAYd5zgLltZ +PyUrfW+qc1ILwbN4WUaDl+LmmXTlMvw9upxUZPJu6VuHBkpk2jnAXgZO0Aae5Sq 2OH2vH7boe7PSVLIdPkYEtZo1EcxADEF0WprU+ugbTcSWUNycQOVFMLFu+5zx8IM 97gbKPlIkvIfFfFT6yMHNYIqWykFTXPqQy67OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729740759; x= 1729827159; bh=XTVa13tR+JrQP+Nm0IcLHQ01kkxRegQGhNTBHJmwh94=; b=G MoQlOByQX8j/B2A1MrAY+ytclc1NSKQ/hFwu9Nkr7Xo9Fj4JGSghnMpCaPCFx7a4 IdFpMxTxmR+pFMQnkRTrENuxbsVtjgP+Wj4oV+aI4lZEhlquJMs6PGrb6gvcJrEq XVJs+HX1NQawEuFQHelgnOdXbLZVf1VN+FnZupEBaX+K1oxnU3veuDA7naMQEiZ8 tbjNBmY9XDhBLh/LuTbrnZTrA2yjm5XkHI4JZZ6kRt3TrCeUSoRpt+Nw1PRfRkPH lnKZ+G7fe4VshR6geQyBT9Q+PFC+1zImnA4SZDR9VZWKiqVYWLXDMbUwk2bGawRo AMYReIz8IZyNPTi4fxHVA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeikedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpefuvggsrghsthhijohnucfoohhnvogruceoshgvsggrshhtihgrnhessh gvsggrshhmohhnihgrrdgtohhmqeenucggtffrrghtthgvrhhnpefffffhuedtudevlefg ffefiefgvdfgheejgfdtueeljeffhfffvedtheekvdffheenucffohhmrghinhepfihhrg htfihgrdhorhhgpdhsvggsrghsmhhonhhirgdrtghomhenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsvggsrghsthhirghnsehsvggsrghsmh honhhirgdrtghomhdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhr tghpthhtohepghgrnhhimhgrrhgusehtuhhtrgdrihhopdhrtghpthhtohepjeefudeffe esuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhr ghdprhgtphhtthhope X-ME-Proxy: Feedback-ID: iab2c46da:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Oct 2024 23:32:38 -0400 (EDT) In-Reply-To: <86613F3D-B7C8-4498-B435-7AAF342264C2@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Wed, 23 Oct 2024 12:43:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294163 Archived-At: Mattias Engdeg=C3=A5rd writes: > Sebasti=C3=A1n, thanks for your contribution! A few minor points about th= is part: > > 663 (let ((case-fold-search t) > 664 (target > 665 "\\|system +\\(\\\"\\|'\\)+about:legac= y-compat\\)")) > 666 (with-current-buffer response-buffer > > First of all, `case-fold-search` becomes buffer-local if set, so binding = it before changing buffer won't help. You need to do it the other way aroun= d. Thank you for picking this up! Makes wonder what I did wrong when testing, that it worked OK. Will correct it in the next patch. > The regexp is a bit muddled. (Carets here apply to the quoted line below.) > > 665 "\\|system +\\(\\\"\\|'\\)+about:legac= y-compat\\)")) > ...................................^ > Why match the terminating `>` in one branch (without DOCTYPE legacy strin= g) but not the other? The idea was to match exactly a "modern" doctype declaration, or softly a legacy one since they are more likely to have...wonky? markup. > ..................................................^^ > Useless backslash(es) here. Did you mean to include something else? > (Relint found this one, which is what brought me here.) I don't think so, it is an honest mistake. I rarely write regexps in elisp code (or any code, for that matter :) haha), only interactive use > .............................................................^ > Why the `+`? According to the reference, there should be one single or do= uble quote here. > (https://html.spec.whatwg.org/multipage/syntax.html#doctype-legacy-string) > > ................................^^^............^^^ > These two capture groups don't seem to be used; you probably meant to use= non-capturing \(?:...\) brackets. This is correct (just read on non-capturing groups). > ..................................................^^^^^^^^ > A character alternative would be better here: ["']. > > An exact translation of your regexp to the rx notation might be: Despite all the mistakes in the regex above, and a few tries to understand it, the rx notation doesn't really click for me. I am more than happy to use either of the versions you provided. Thank you for your review! --=20 Sebasti=C3=A1n Mon=C3=ADa https://site.sebasmonia.com/