From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#73357: [PATCH] Make vc-clone interactive Date: Thu, 24 Oct 2024 14:19:15 +0000 Message-ID: <877c9xlh24.fsf@posteo.net> References: <875xqrlr3b.fsf@disroot.org> <86ploz935f.fsf@gnu.org> <87y13nk39b.fsf@disroot.org> <87ed59tkpk.fsf@posteo.net> <871q12fhf2.fsf@disroot.org> <87jzesulk7.fsf@posteo.net> <87y131ffox.fsf@disroot.org> <86msj9wmna.fsf@gnu.org> <874j516bwk.fsf@disroot.org> <87sesl93xe.fsf@posteo.net> <87a5et4u90.fsf@melete.silentflame.com> <87wmhx4r7k.fsf@disroot.org> <87ikth3989.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32852"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , 73357-done@debbugs.gnu.org, Aleksandr Vityazev To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 24 16:19:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3ygv-0008Nm-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Oct 2024 16:19:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3ygY-0007bm-V2; Thu, 24 Oct 2024 10:19:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3ygW-0007bH-FQ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 10:19:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3ygV-00060W-Rd for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 10:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=G1Xci9YnQ8+TtV3rhJOgzHQvoloKC8y18RPM9pj5u60=; b=lYtRVZEBtsL69pKsnJMN8q2BlHEoGasR9wFgUa85xHysl9/Hu5wK+XWuqrpd2l4W0Yx7r1tpqAVq7tMN426f+zp2bYgdLkbNn/z4qPUVmPVp7pbfC2oDZ4aDWLCGaaNXU0yqc1DEo2B4SVoiWM7bdRWRMWayZXJOcTGoYRDRzIA7Mn75Qez47XSjXSg1HWukxlZQFuC3jrHicT3fEJFMZhofONgE0en9pd2oq7X2Tbq9zq6WYaPV0elUZ+TMxZMzvSc9Mb7Gavmywxc+JIPrUjpBmZxlSRHUXwJfJOf3WUq/BzVk2c5Uj1A0YCgRTKCNbii38vLmN4JXKLyJvb7gLA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t3ygz-0006S0-Th for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2024 10:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2024 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73357-done@debbugs.gnu.org id=D73357.172977959724779 (code D ref 73357); Thu, 24 Oct 2024 14:20:01 +0000 Original-Received: (at 73357-done) by debbugs.gnu.org; 24 Oct 2024 14:19:57 +0000 Original-Received: from localhost ([127.0.0.1]:35812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ygv-0006Rb-4G for submit@debbugs.gnu.org; Thu, 24 Oct 2024 10:19:57 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t3ygs-0006RL-9c for 73357-done@debbugs.gnu.org; Thu, 24 Oct 2024 10:19:56 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 85190240027 for <73357-done@debbugs.gnu.org>; Thu, 24 Oct 2024 16:19:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1729779557; bh=BuqSMHPHgpJh6a5ln0IFb/FIejRCe65V4Wt01AQdLFs=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=UzKPQmpQdF/WHERGdjN38xZ9i+s6YVRloWnJ2wX8dmOyJpOpLlwYh+9zOx1PTQ7M+ 1Fn2+gV1CfCsbuXjs2AVMZ5GZsXQvFis6JB2psyUDVXRzjZz0GakU+vfe8E/Wk05pu H/2JFXC3Cy095aHloaw7LqUZreLUrriLq0Pzc8ZzQFkEIKEMe7OeFzmz092GaiQ/AM PyhcwKBpNaFz6UZKBlJpoB9dW5Ssja+V6cxwrNFVI9C6ZmqydjjmRd+6HaNtj8XDyH FOzYViO7rZVf8v4vnNKto5cgCcdmgAIFidAXgHi2ZQqpMyg/ZEB0rEaJ2C0kAjOhWx k/GSGYZFryLmw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XZ7MR6bX8z9rxG; Thu, 24 Oct 2024 16:19:15 +0200 (CEST) In-Reply-To: <87ikth3989.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 24 Oct 2024 21:45:42 +0800") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294192 Archived-At: Sean Whitton writes: > Hello, > > On Thu 24 Oct 2024 at 03:31pm +03, Aleksandr Vityazev wrote: > >> I don't have a strong opinion on this. I originally proposed this: >> >> (when (file-directory-p directory) >> (if (called-interactively-p 'interactive) >> (find-file directory) >> directory)) >> >> The OPEN-DIR argument was suggested by Philip, and I agreed with him, >> since the option is also good. I'm fine with both options, I'll do as >> you say. > > Sorry, I misread the code, ignore my comment here. > >> V5 patches: > > Installed, thanks. > > I renamed vc-backend-type and vc-heuristic-alist to less generic names. > > I also realised that vc-clone now can call vc-guess-url-backend even > when noninteractive, and it always returns DIRECTORY which it didn't > before, so I updated the commit message accordingly. This is important, as package-vc calls vc-clone non-interactively. -- Philip Kaludercic on siskin