From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables Date: Mon, 16 Dec 2024 19:15:03 +0100 Message-ID: <877c7z5wbc.fsf@gmail.com> References: <48132.687299379$1734370474@news.gmane.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23810"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Bj=C3=B6rn?= Bidar To: 74915@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 16 19:17:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNFf1-0005z3-6S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Dec 2024 19:17:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNFen-0005Ef-6t; Mon, 16 Dec 2024 13:17:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNFeT-0005B3-GO for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 13:17:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNFeQ-0001mA-G3 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 13:17:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HoHozKVLpqKtzYLQD/yKTacF72TVhn3y1Xe9mvpx2bs=; b=e94qPXUO/VDYWKlQLeZVitlCJmN2wX1Cbh3yoc8KwogeDcWBFgVP3tNwCdNhAgR/jixboxXLfg5RV1sQYF+tZ8zvXSFG5Ot4WjqEC1WU9PEOMscb2Xy9VBhnSWguI4fP6Ej9M+uEMiVyFx0KGdYfIm1wV+Lt2+uHMdwqKz+cteLf9IYxBy3wU8eUGYoGHjEDwXCUzGngpFL3KgE/keQWJDK3qdoY3lD9UDfz/nG80QCLsgIrtHTSLrrgn3pQY/jb3msKmlN/2Qd4NRLL0y6rd4MvFWjhnVSgnXc8fjm+ymc3X4FDl5GTxMtpXzp2Tp9v/ZwXtctNZnB8VeRM+AqNTA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNFeQ-0000lL-0x for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 13:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 18:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74915-submit@debbugs.gnu.org id=B74915.17343729682810 (code B ref 74915); Mon, 16 Dec 2024 18:17:01 +0000 Original-Received: (at 74915) by debbugs.gnu.org; 16 Dec 2024 18:16:08 +0000 Original-Received: from localhost ([127.0.0.1]:56109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNFdY-0000jG-E7 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 13:16:08 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:44481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNFdW-0000j2-0P for 74915@debbugs.gnu.org; Mon, 16 Dec 2024 13:16:07 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43618283d48so31984755e9.1 for <74915@debbugs.gnu.org>; Mon, 16 Dec 2024 10:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734372905; x=1734977705; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=HoHozKVLpqKtzYLQD/yKTacF72TVhn3y1Xe9mvpx2bs=; b=IsrOo8W2nWUK3Hn0THOvwFGQ7gODyi6VT/sD+IekbuCnkwL+RGxCcbdonmB7ildHor MN8gbdLMyblE+xFPUWfT74niUzBk0+BgiKIpEonSELmeh4WqoHh/phiFlGnzpvGh01x0 1uc+OexwR6lHcMymNbjVY9YHW8MSZ6+Auu42bB1GshBqR5cnBbIvRoyWSueTynTciu4X Vq75KIysH6pDsQ06Ph9i6jDndrTmsL4h8PfWDYjxgPkOlWFQVfm7L8pABT3weA80N0ps sAeHvHs/TL+i/UVsnJezwqkDoAP4TDmM1abM5O9bg0C5DEKtdEblzDeRmrFSbkgU/zuo HbGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734372905; x=1734977705; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HoHozKVLpqKtzYLQD/yKTacF72TVhn3y1Xe9mvpx2bs=; b=KdblsyPa5khnmK3XNp6HvO5JekUjXfLbKBiHG44jvPQg1LC2YO5XSRFp70MjLFXFap hKU7mCEBZU5zTaAeCqswNz2W6TMA7zuSrhRAw39q4srkKpTIpW3UoXond2UNJAGB8ooQ hUwzk56jjuJNVxYcEQnM7SzFrdi8mYvyJy6kOwRpq0SXThISj3+czptOCgKPrZ/kPBkP gELHPGTWBkNnfMR7D3AtZCQWGIM0VYx0UDoLZx9VtQq3ti3WzfniHSCLJDYv4LBC153k H1k6NGCvKBhqD8+FgVriR41qx6u7RLwjx+zv5M6ZTo1b/QHtXu1kGVaxC4Sb9xC+GOGW UdRg== X-Gm-Message-State: AOJu0Yz4lm8ct1+d2H11Ghv/VsUXX1M85xIhKpv9Lvwue2yuAFiC6vox mb0IUUVeXbjkEiox0nkU00iHfht5n4rjhtOkLnl5uvM6M60qutckE0Cy9A== X-Gm-Gg: ASbGncsM5yVvVXGs+ivhDWueR+/zqJfCz/hmCnwvQMi0oU15DQsRDcHWtmhSTiivoT1 Z/84JP/cmOv+1brP153/Vsx8iYux5SgP4r9QcI4Gwhxh09Wv1yZYWYjn4PUpOIfWZ0JyRVxg1rh gCmY+sLx74NhPcnHdB7KW7BlnS4MHIiexYbh52l30PPu69M5dvzgo5yRY3onu7+As3LJ7AeJVMw 2JUrsni0JZy8nC2WL28B5genc/y5hirIsmEyDoaxn4= X-Google-Smtp-Source: AGHT+IHtRBePFkcrVxOvLx8M8bSH38b9BgFWjIWaRQFoud1zfQHwJPtFi13BK28UMwj/J+65xq07Xw== X-Received: by 2002:a05:6000:400b:b0:385:e30a:e0f7 with SMTP id ffacd0b85a97d-388da3940c6mr564741f8f.22.1734372905044; Mon, 16 Dec 2024 10:15:05 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:a104:d8c:5af4:8136]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8015f77sm8751470f8f.26.2024.12.16.10.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 10:15:04 -0800 (PST) In-Reply-To: <48132.687299379$1734370474@news.gmane.org> ("=?UTF-8?Q?Bj=C3=B6rn?= Bidar via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Mon, 16 Dec 2024 19:33:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297207 Archived-At: >>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Bj=C3=B6rn Bidar via "Bug reports= for GNU Emacs, the Swiss army knife of text editors" said: Bj=C3=B6rn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00= :00:00 2001 Bj=C3=B6rn> From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D Bj=C3=B6rn> Date: Mon, 16 Dec 2024 19:20:00 +0200 Bj=C3=B6rn> Subject: [PATCH] Fix custom types of gnus-article-treat-hea= d-custom variables Bj=C3=B6rn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-trea= t-date) Bj=C3=B6rn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers) Bj=C3=B6rn> (gnus-treat-highlight-headers, gnus-treat-display-x-face) Bj=C3=B6rn> (gnus-treat-display-face, gnus-treat-display-face) Bj=C3=B6rn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon) Bj=C3=B6rn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar) Bj=C3=B6rn> (gnus-treat-body-boundary): Fix custom types to Bj=C3=B6rn> include all possible choices mentioned in the docstrings Bj=C3=B6rn> and manual. The commit message only needs to mention the type you actually changed, in this case `gnus-article-treat-head-custom' Bj=C3=B6rn> --- Bj=C3=B6rn> lisp/gnus/gnus-art.el | 5 ++++- Bj=C3=B6rn> 1 file changed, 4 insertions(+), 1 deletion(-) Bj=C3=B6rn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el Bj=C3=B6rn> index 8243e4e632b..13dfb737243 100644 Bj=C3=B6rn> --- a/lisp/gnus/gnus-art.el Bj=C3=B6rn> +++ b/lisp/gnus/gnus-art.el Bj=C3=B6rn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom =20 Bj=C3=B6rn> (defvar gnus-article-treat-head-custom Bj=C3=B6rn> '(choice (const :tag "Off" nil) Bj=C3=B6rn> - (const :tag "Header" head))) Bj=C3=B6rn> + (const :tag "Header" head) Bj=C3=B6rn> + (const :tag "First" first) Bj=C3=B6rn> + (const :tag "Last" last) Bj=C3=B6rn> + (boolean :tag "All body parts" t))) `t' is a const, not a boolean, the same as `nil', in the context of defcustom. Plus a lot of the docstrings look cut&paste, so I=CA=BCm not entirely sure that it=CA=BCs the existing type that is wrong rather than the docstring. Robert --=20