From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Hong Xu Newsgroups: gmane.emacs.bugs Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Fri, 20 Dec 2024 13:50:15 -0800 Message-ID: <877c7u58iw.fsf@topbug.net> References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33219"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.8; emacs 29.4 Cc: Stefan Kangas , 74983@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 22:51:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOku6-0008QY-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 22:51:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOktk-0006jm-Pl; Fri, 20 Dec 2024 16:51:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOktj-0006je-AA for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 16:51:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOkti-0004RE-HB for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 16:51:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=XVrv6OTjsFrGt/Zx9qidfyJ7oMaj3bCceDNWiFF/QuI=; b=dPkK1ShFWfuLSs/5KH6dgnANvdQF1+pJrc8r6lPTU5phw+H0Y9d3KucUXaqrLf+hlMHBvGrca+oO0SRYZFUmek51NnGLtZuepQ/L0ypShvCtwopl9FPIEum0hfuOiHvYQ4uBb3XHxGv5jr+bsy1gJT3u4axT8qoCijlaUFHP05lMKNV2RdEIR0IoI8lA6rLKJ+Wf0485Gmdl2L1mVdmRTSSMw3H+7Apwqe3z3BvSC8QBInLEEywS40q+0xGYSFHnX3AODu4iUwMCf52IFknpW+dy1dNdx/TcmaqyIXwK4je9hqbCnQ3Sn2P05kwbTww9tseHWLYBIL9KcafRKdyqsg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOkti-0008Qq-0c for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 16:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Hong Xu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74983-submit@debbugs.gnu.org id=B74983.173473143232367 (code B ref 74983); Fri, 20 Dec 2024 21:51:01 +0000 Original-Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 21:50:32 +0000 Original-Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOktE-0008Pz-Ae for submit@debbugs.gnu.org; Fri, 20 Dec 2024 16:50:32 -0500 Original-Received: from sender4-of-o52.zoho.com ([136.143.188.52]:21297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOktA-0008Pp-Af for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 16:50:31 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1734731419; cv=none; d=zohomail.com; s=zohoarc; b=YYhs154hDxV9sNR1XsUUdwiAPCqdzQsoTE7fyKlxNgtxX2vT4qkU4hfGY9WA0ZisJf6PUxUSke2E2SjMzA/hZTM2SljCw3nCOQ+JR08jy065IT82/ahe19yD/+o+z2vaJ6ch4G+NNaI/Kk+xtTDyHP66Exn4q4CGua0WcvVPz7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734731419; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XVrv6OTjsFrGt/Zx9qidfyJ7oMaj3bCceDNWiFF/QuI=; b=JcNdXEfFqwmfi8KEKG6l9TRB/Qs1YscKYDhYgxmfOAu6qWpTb5vh5HYaf6/sX2qZffysBQtuQGBseymdmx2FyX1SXuicQ+iR6iFbhLj1ggDFNz+Kk4MAeTIcEGXS55vpx22SW4kApvfA980w/+VMKmuQMY4lZBndwXDxA2oU2TU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1734731419; s=zoho; d=topbug.net; i=hong@topbug.net; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=XVrv6OTjsFrGt/Zx9qidfyJ7oMaj3bCceDNWiFF/QuI=; b=VP2zZP0JzUVnJy3vUDOAjDjKnR4w29HnJpq3IUJXC6ZZWfn2192fPSSlR0rLl0sa XRd69hb5MRAM40MiJqxGkMetlEkhoIZM70hMIhaybcH4hq5EunSBjVqDVd97dbG6aLC du6OjgHKZO2sGpTWo+hZOsze4nky90myVUCQQWww= Original-Received: by mx.zohomail.com with SMTPS id 1734731416348196.17964682139427; Fri, 20 Dec 2024 13:50:16 -0800 (PST) In-Reply-To: <86pllmkfcm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2024 09:01:29 +0200") X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297479 Archived-At: On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii wrote: >> From: Hong Xu >> Date: Thu, 19 Dec 2024 14:36:29 -0800 >> >> * Since `define-key' is considered legacy and we encourage `keymap-set' >> now. > > Thanks. But the second chunk is not really right, since we have many > more define-key there than keymap-set. > > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. Thanks, I agree. I've made a followup patch. For some reason the followup patch didn't attach to the Message ID of this thread and a new bug 74999 was created. -- Hong