From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Yuan Fu <casouri@gmail.com>, Dmitry Gutov <dmitry@gutov.dev>
Cc: Eli Zaretskii <eliz@gnu.org>, 73978-done@debbugs.gnu.org
Subject: bug#73978: 31.0.50; Text syntax applied on too many things in tsx-ts-mode
Date: Sun, 05 Jan 2025 12:55:11 +0100 [thread overview]
Message-ID: <877c79v5k0.fsf@thornhill.no> (raw)
In-Reply-To: <F3C21F12-3FB6-41EB-BED1-C6AF35EF5819@gmail.com>
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 12, 2024, at 9:19 AM, Dmitry Gutov <dmitry@gutov.dev> wrote:
>>
>> On 12/12/2024 06:56, Yuan Fu wrote:
>>> How hard is it to add a new syntax for this case? Or is there some way to work around this? We can’t just not apply the string syntax, because if the “a” is a parenthesis, etc, it would mess up the parenthesis balancing after it.
>>
>> Probably not very hard, but that seems like it'd affect the total set of syntax classes - which means adding it to the manual, etc.
>>
>>> Maybe just give it a whitespace syntax?
>>
>> Right, in such cases I applied the "whitespace" or "punctuation" syntax to the whole character span, like in https://github.com/dgutov/mmm-mode/blob/master/mmm-erb.el#L97
>
> Thanks. I went with the whitespace trick and pushed my patch to master.
>
> Yuan
FWIW, I believe this is a regression caused by later versions of the
treesit grammar. What is talked about here was explicitly a goal for me
to handle at least better than what it appears it has been for some
time. IIRC they changed what nodes were applied as the jsx nodes quite
dramatically some time ago. I'm not surprised there are issues after
that, as most wasn't backward compatible
Theo
next prev parent reply other threads:[~2025-01-05 11:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 4:06 bug#73978: 31.0.50; Text syntax applied on too many things in tsx-ts-mode Yuan Fu
2024-11-09 9:11 ` Eli Zaretskii
2024-11-09 16:49 ` Yuan Fu
2024-11-23 12:15 ` Eli Zaretskii
2024-11-24 5:25 ` Yuan Fu
2024-11-24 7:47 ` Eli Zaretskii
2024-11-24 13:45 ` Dmitry Gutov
2024-11-25 1:27 ` Yuan Fu
2024-12-11 4:52 ` Yuan Fu
2024-12-12 2:52 ` Dmitry Gutov
2024-12-12 4:56 ` Yuan Fu
2024-12-12 17:19 ` Dmitry Gutov
2024-12-13 5:47 ` Yuan Fu
2025-01-05 11:55 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2025-01-05 14:13 ` Daniel Colascione
2024-12-24 7:59 ` Juri Linkov
2024-12-24 8:31 ` Juri Linkov
2024-12-24 8:52 ` Yuan Fu
2024-12-24 17:25 ` Juri Linkov
2024-12-24 20:57 ` Yuan Fu
2024-12-25 7:40 ` Juri Linkov
2024-12-25 8:33 ` Yuan Fu
2024-12-26 5:37 ` Dmitry Gutov
2025-01-04 19:58 ` Yuan Fu
2025-01-05 7:57 ` Juri Linkov
2025-01-05 8:21 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c79v5k0.fsf@thornhill.no \
--to=bug-gnu-emacs@gnu.org \
--cc=73978-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).