From: Juri Linkov <juri@jurta.org>
To: Eli Barzilay <eli@barzilay.org>
Cc: 4117@emacsbugs.donarmstrong.com
Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift
Date: Mon, 17 Aug 2009 03:47:57 +0300 [thread overview]
Message-ID: <8763cn1bne.fsf@mail.jurta.org> (raw)
In-Reply-To: <19079.19475.169507.668553@winooski.ccs.neu.edu> (Eli Barzilay's message of "Sat, 15 Aug 2009 20:00:19 -0400")
>> It's interesting that after loading s-region.el, your reported case
>> works correctly without fixes.
>>
>> So it seems the current core shift-selection is not the exact
>> re-implementation of s-region.el.
>
> I still believe that the problem is somewhere in how
> `isearch-other-meta-char' restores the key. FWIW, here is my hack; I
> can't even explain how it works since I was basically guessing my way
> trying to get the stupid thing to work.
>
> At least in v22, this would cause the key that is used to exit isearch
> to be replayed twice -- for example, using `C-x 2' would happen twice.
> It just happens that I'm personally much more likely to shift-arrow my
> way out of isearch than I am to splitting the window.
Could you try the following hack:
Index: lisp/isearch.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/isearch.el,v
retrieving revision 1.345
diff -u -r1.345 isearch.el
--- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345
+++ lisp/isearch.el 17 Aug 2009 00:47:38 -0000
@@ -1900,6 +1905,12 @@
((and isearch-allow-scroll
(progn (setq key (isearch-reread-key-sequence-naturally keylist))
(setq keylist (listify-key-sequence key))
+ (when this-command-keys-shift-translated
+ (setq keylist (list
+ (event-convert-list
+ (append (cons 'shift (event-modifiers keylist))
+ (list (event-basic-type keylist))))))
+ (setq this-command-keys-shift-translated nil))
(setq main-event (aref key 0))
(setq scroll-command (isearch-lookup-scroll-key key))))
;; From this point onwards, KEY, KEYLIST and MAIN-EVENT hold a
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-08-17 0:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 10:48 bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Eli Barzilay
2009-08-12 20:54 ` Juri Linkov
2009-08-12 23:59 ` Eli Barzilay
2009-08-15 23:27 ` Juri Linkov
2009-08-16 0:00 ` Eli Barzilay
2009-08-17 0:47 ` Juri Linkov [this message]
2009-08-17 3:17 ` Eli Barzilay
2009-08-17 15:07 ` Stefan Monnier
2009-08-17 19:53 ` Eli Barzilay
2009-08-17 21:19 ` Juri Linkov
2009-08-17 21:18 ` Juri Linkov
2009-08-18 2:56 ` Stefan Monnier
2009-08-19 0:56 ` Juri Linkov
2009-08-19 3:27 ` Stefan Monnier
2016-06-18 3:53 ` Andrew Hyatt
[not found] ` <mailman.1719.1466222049.1216.bug-gnu-emacs@gnu.org>
2016-06-19 13:18 ` Alan Mackenzie
[not found] <<19073.19554.183166.905858@winooski.ccs.neu.edu>
[not found] ` <<20160619131846.68080.qmail@mail.muc.de>
2016-06-19 14:36 ` Drew Adams
2016-06-20 0:57 ` Andrew Hyatt
2016-06-20 3:50 ` Eli Barzilay
2016-06-23 3:23 ` Andrew Hyatt
2016-06-23 4:18 ` Eli Barzilay
2016-06-23 18:15 ` Andrew Hyatt
2016-07-07 17:23 ` Eli Barzilay
2016-07-09 12:38 ` Andrew Hyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763cn1bne.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=4117@emacsbugs.donarmstrong.com \
--cc=eli@barzilay.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).