From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#8364: 24.0.9999; PATCH: Fit to width/height/page for doc-view.el Date: Wed, 30 Mar 2011 17:08:52 +0200 Message-ID: <8762r0wsqj.fsf@member.fsf.org> References: <878vvz8sml.fsf@fastmail.fm> <87k4fj6z8e.fsf@member.fsf.org> <87hbanw3ll.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301499506 18531 80.91.229.12 (30 Mar 2011 15:38:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Mar 2011 15:38:26 +0000 (UTC) Cc: sho nakatani , 8364@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 30 17:38:21 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4xTP-0002Pf-GU for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Mar 2011 17:38:21 +0200 Original-Received: from localhost ([127.0.0.1]:34273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4xTH-0002R7-Mr for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Mar 2011 11:38:11 -0400 Original-Received: from [140.186.70.92] (port=33721 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4xSR-00025k-Pg for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 11:37:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4xSJ-0007hf-PM for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 11:37:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4xSJ-0007ha-NZ for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2011 11:37:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q4x14-0002hH-Hr; Wed, 30 Mar 2011 11:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2011 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8364-submit@debbugs.gnu.org id=B8364.130149774110359 (code B ref 8364); Wed, 30 Mar 2011 15:09:02 +0000 Original-Received: (at 8364) by debbugs.gnu.org; 30 Mar 2011 15:09:01 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4x12-0002h2-7N for submit@debbugs.gnu.org; Wed, 30 Mar 2011 11:09:00 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4x11-0002gr-5u for 8364@debbugs.gnu.org; Wed, 30 Mar 2011 11:08:59 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 53B1C7816F90; Wed, 30 Mar 2011 17:08:53 +0200 (CEST) Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16410-05; Wed, 30 Mar 2011 17:08:52 +0200 (CEST) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from thinkpad (tsdh.uni-koblenz.de [141.26.67.142]) by deliver.uni-koblenz.de (Postfix) with ESMTP id B405C7816FB1; Wed, 30 Mar 2011 17:08:52 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed, 30 Mar 2011 10:42:27 -0400") User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.9999 (gnu/linux) X-Virus-Scanned: amavisd-new at uni-koblenz.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Mar 2011 11:09:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45503 Archived-At: Stefan Monnier writes: >> I'm trying to add `fit-slice-to-window' feature in doc-view.el. > > Nice, thanks. BTW, maybe an even better functionality is > "fit-rectangle-to-window", which would do the same except without > slicing (i.e. move the top-left corner and zoom so only the specified > rectangle is visible, but while keeping the outside visible via > scrolling). Where's the difference, except that you could scroll the margins if you wanted to do so? Implementation-wise, the difference is that Nakatani's current approach simply uses the image slice for the geometry, your rectangle approach requires another buffer-local variable. And since slices are there anyway, I prefer making fitting functions do the right thing in that scenario. You can already zoom and hscroll until you have the visible rectangle you like to have, and all doc-view navigation commands preserve the hscroll. Bye, Tassilo