From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#8279: [PATCH] More fixes to prevent hide-show from being confused by commented-out braces Date: Sat, 28 May 2011 14:35:57 -0400 Message-ID: <8762our7ua.fsf@stupidchicken.com> References: <20110318003315.788002f0@smart> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306607831 26710 80.91.229.12 (28 May 2011 18:37:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 May 2011 18:37:11 +0000 (UTC) Cc: 8279@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 28 20:37:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQONm-0002qM-GL for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 May 2011 20:37:06 +0200 Original-Received: from localhost ([::1]:43244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQONm-0004b8-0u for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 May 2011 14:37:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQONj-0004aj-Ix for bug-gnu-emacs@gnu.org; Sat, 28 May 2011 14:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQONi-0003Jy-HZ for bug-gnu-emacs@gnu.org; Sat, 28 May 2011 14:37:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQONi-0003Ju-Az for bug-gnu-emacs@gnu.org; Sat, 28 May 2011 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QQONh-0007r5-O1; Sat, 28 May 2011 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 May 2011 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8279-submit@debbugs.gnu.org id=B8279.130660776830124 (code B ref 8279); Sat, 28 May 2011 18:37:01 +0000 Original-Received: (at 8279) by debbugs.gnu.org; 28 May 2011 18:36:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOMq-0007pp-9q for submit@debbugs.gnu.org; Sat, 28 May 2011 14:36:08 -0400 Original-Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQOMo-0007pV-RL for 8279@debbugs.gnu.org; Sat, 28 May 2011 14:36:07 -0400 Original-Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p4SIZwMa015681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 May 2011 14:35:59 -0400 Original-Received: by furball (Postfix, from userid 1000) id 055E116031F; Sat, 28 May 2011 14:35:57 -0400 (EDT) In-Reply-To: <20110318003315.788002f0@smart> (Dima Kogan's message of "Fri, 18 Mar 2011 00:33:15 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 28 May 2011 14:37:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46756 Archived-At: Dima Kogan writes: > Earlier I submitted some fixes to hideshow.el to improve handling of > braces in comments (bug#8036). These fixes were incomplete and in one > case, incorrect. The attached patch improves hideshow.el further: + "Returns non-nil if the point is at the block start. +A function is useful for this to cleanly disregard commented-out +blocks" This docstring should use the active voice, i.e. "Returns non-nil if the point is at the block start." And there's no need to justify the use of a function. Otherwise, the patch looks reasonable; I've commited it. Thanks.