From: Chong Yidong <cyd@stupidchicken.com>
To: Dima Kogan <dkogan@cds.caltech.edu>
Cc: 8279@debbugs.gnu.org
Subject: bug#8279: [PATCH] More fixes to prevent hide-show from being confused by commented-out braces
Date: Sat, 28 May 2011 14:35:57 -0400 [thread overview]
Message-ID: <8762our7ua.fsf@stupidchicken.com> (raw)
In-Reply-To: <20110318003315.788002f0@smart> (Dima Kogan's message of "Fri, 18 Mar 2011 00:33:15 -0700")
Dima Kogan <dkogan@cds.caltech.edu> writes:
> Earlier I submitted some fixes to hideshow.el to improve handling of
> braces in comments (bug#8036). These fixes were incomplete and in one
> case, incorrect. The attached patch improves hideshow.el further:
+ "Returns non-nil if the point is at the block start.
+A function is useful for this to cleanly disregard commented-out
+blocks"
This docstring should use the active voice, i.e. "Returns non-nil if the
point is at the block start." And there's no need to justify the use of
a function.
Otherwise, the patch looks reasonable; I've commited it. Thanks.
prev parent reply other threads:[~2011-05-28 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 7:33 bug#8279: [PATCH] More fixes to prevent hide-show from being confused by commented-out braces Dima Kogan
2011-05-28 18:35 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762our7ua.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=8279@debbugs.gnu.org \
--cc=dkogan@cds.caltech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).