From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 13 Jan 2012 23:51:52 +0100 Message-ID: <8762gfnrlj.fsf@gmx.de> References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326495156 14122 80.91.229.12 (13 Jan 2012 22:52:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2012 22:52:36 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Thierry Volpiatto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 13 23:52:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rlpz1-0004AI-BE for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 23:52:27 +0100 Original-Received: from localhost ([::1]:53666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlpz0-0008An-Vc for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 17:52:26 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:34333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlpyy-0008Aa-MX for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 17:52:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rlpyx-0005c6-7k for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 17:52:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlpyx-0005c1-6C for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 17:52:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RlpzZ-0007HS-PA for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 17:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jan 2012 22:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132649516327959 (code B ref 10489); Fri, 13 Jan 2012 22:53:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 13 Jan 2012 22:52:43 +0000 Original-Received: from localhost ([127.0.0.1]:56892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlpzH-0007Gu-3s for submit@debbugs.gnu.org; Fri, 13 Jan 2012 17:52:43 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:52686) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1RlpzD-0007Gk-T7 for 10489@debbugs.gnu.org; Fri, 13 Jan 2012 17:52:41 -0500 Original-Received: (qmail invoked by alias); 13 Jan 2012 22:51:58 -0000 Original-Received: from p57BB9670.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.150.112] by mail.gmx.net (mp026) with SMTP; 13 Jan 2012 23:51:58 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19+JSs0Rc1+eVOhLJFok1YFmiOVJH3M/Q7czAunaO 8maBtN6xiVDKtH In-Reply-To: (Stefan Monnier's message of "Fri, 13 Jan 2012 14:43:43 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55719 Archived-At: Stefan Monnier writes: >> What about this? >> (defun file-name-equal-p (name1 name2 &optional dir) >> (let* ((n1 (file-truename (expand-file-name name1 dir))) > > There's a crucial line missing between the above two. It should clearly > document what this function is expected to do. E.g. it should make it > clear if (and if so, to what extent) the function is allowed to refer to > the actual file system(s) as opposed to only relying on the > provided strings. If the file name strings are not obviously equal, `file-truename' will refer to the underlying file system(s). There will be some checks to avoid this for remote files, for example due to different host names used in both file names, but this are implementation details. This is the difference to `file-remote-p', which works only with the given file name strings. Something like (defun file-equal-p (name1 name2 &optional dir) "Return non-nil if NAME1 and NAME2 refer to the same file in the file system. If either name is not absolute, then it is expanded relative to DIR (if given) or `default-directory' for the test." (let ((fn1 (expand-file-name name1 dir)) (fn2 (expand-file-name name2 dir))) (cond ((string-equal fn1 fn2)) ((and (file-remote-p fn1) (file-remote-p fn2)) (let ((handler (or (find-file-name-handler fn1 'file-equal-p) (find-file-name-handler fn2 'file-equal-p)))) (if handler (funcall handler 'file-equal-p name1 name2 dir)))) ((or (file-remote-p fn1) (file-remote-p fn2)) nil) (t (if the-var-which-tells-us-case-insensitivity (string-equal (downcase (file-truename fn1)) (downcase (file-truename fn1))) (string-equal (file-truename fn1) (file-truename fn1)))))) > Stefan Best regards, Michael.