unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Ken Raeburn <raeburn@permabit.com>
Cc: 10744@debbugs.gnu.org
Subject: bug#10744: 24.0.93; dbus notification callback error
Date: Tue, 07 Feb 2012 10:09:22 +0100	[thread overview]
Message-ID: <8762fjxb5p.fsf@gmx.de> (raw)
In-Reply-To: <6e62fj77og.fsf@just-testing.permabit.com> (Ken Raeburn's message of "Mon, 06 Feb 2012 20:29:03 -0500")

Ken Raeburn <raeburn@permabit.com> writes:

> An error pops up indicating that notifications-on-closed-signal is
> passed one argument instead of the expected two:
>
> Debugger entered--Lisp error: (wrong-number-of-arguments #[(id reason) ...] 1)
>   notifications-on-closed-signal(673)

According to the spec, the NotificationClosed signal shall send 2
arguments, the id and the reason. See
<http://www.galago-project.org/specs/notification/0.9/x408.html#signal-notification-closed>.

That's what `notifications-on-closed-signal' expects. And doesn't get.

>   dbus-handle-event((dbus-event :session 4 1352 ":1.12" "/org/freedesktop/Notifications" "org.freedesktop.Notifications" "NotificationClosed" notifications-on-closed-signal 673))

The daemon sends only one argument, the id (673). I could reproduce the
problem on an old RHEL system with:

notification-daemon.x86_64               0.3.5-9.el5 installed

Reading the NEWS entry of the notification-daemon sources, I've found

version 0.4.0 (20-November-2008):
        * Send the reason code along with the NotificationClosed signal in order
          to indicate why the notification was closed. (Bug #137)

So it is clearly a daemon error, which is corrected meanwhile. I've
submitted a fix to the trunk, making the reason argument in
`notifications-on-closed-signal' optional (assuming `undefined' as
default). Could you, please, check?

Best regards, Michael.





  reply	other threads:[~2012-02-07  9:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07  1:29 bug#10744: 24.0.93; dbus notification callback error Ken Raeburn
2012-02-07  9:09 ` Michael Albinus [this message]
2012-02-11  0:02   ` Ken Raeburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762fjxb5p.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=10744@debbugs.gnu.org \
    --cc=raeburn@permabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).