unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#11354: 24.1.50; long lines (214 chars!) in files.el
@ 2012-04-26 16:22 Drew Adams
  2012-04-26 17:09 ` Chong Yidong
  2012-04-26 18:30 ` Stefan Monnier
  0 siblings, 2 replies; 8+ messages in thread
From: Drew Adams @ 2012-04-26 16:22 UTC (permalink / raw)
  To: 11354

Emacs Dev makes a big deal about line length whenever anyone submits
code or a patch for inclusion.  Yet you keep using extremely long
lines yourselves.
 
files.el now has a max width of 214 chars!  Supposedly the limit is 80
chars or so.  At least reduce the line lengths to something reasonable.
 
This is not even a code problem (e.g. long function def with many
nesting levels).  It is simply a result of forgetting to use `\' to chop
long strings.  Please DTRT.
 
Here's the longest line, but there are plenty of others that are also
far too long:
 
 
("\\`/etc/\\(?:DIR_COLORS\\|ethers\\|.?fstab\\|.*hosts\\|lesskey\\|login\\.?de\\
(?:fs\\|vperm\\)\\|magic\\|mtab\\|pam\\.d/.*\\|permissions\\(?:\\.d/.+\\)?\\|pro
tocols\\|rpc\\|services\\)\\'" . conf-space-mode)
 
Just chop it:
 
 
("\\`/etc/\\(?:DIR_COLORS\\|ethers\\|.?fstab\\|.*hosts\\|lesskey\\|login\\.?de\
\\(?:fs\\|vperm\\)\\|magic\\|mtab\\|pam\\.d/.*\\|permissions\\(?:\\.d/.+\\)?\
\\|protocols\\|rpc\\|services\\)\\'" . conf-space-mode)


In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600)
 of 2012-04-23 on MARVIN
Bzr revision: 108006
agustin.martin@hispalinux.es-20120423103325-xmra3329elgzhmpc
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 






^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-04-26 20:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-26 16:22 bug#11354: 24.1.50; long lines (214 chars!) in files.el Drew Adams
2012-04-26 17:09 ` Chong Yidong
2012-04-26 17:32   ` Drew Adams
2012-04-26 17:46     ` Eli Zaretskii
2012-04-26 18:11       ` Drew Adams
2012-04-26 18:30 ` Stefan Monnier
2012-04-26 18:49   ` Drew Adams
2012-04-26 20:59     ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).