unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: 12854@debbugs.gnu.org
Subject: bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented
Date: Sun, 18 Nov 2012 02:00:54 +0100	[thread overview]
Message-ID: <876253u3ll.fsf@web.de> (raw)
In-Reply-To: <50A65CA3.5070701@gmx.at> (martin rudalics's message of "Fri, 16 Nov 2012 16:32:51 +0100")

martin rudalics <rudalics@gmx.at> writes:

> > (1) If CONDITION is a function, it currently must be a symbol.  I don't
> > see why lambda expressions should be forbidden.  The user should not
> > need to use defun only to be able specify an argument.
>
> I lifted this restriction in revision 110885 on the Emacs-24 release
> branch.

Ok, thanks.  My stuff works now as it's supposed to.

> > (2) If CONDITION is a function, it takes _two_ arguments: a buffer
> > _name_ (not a buffer) _and_ an alist.  That should be clarified in the
> > docstring.
>
> As a matter of fact, the code called that function with the variable
> `display-buffer-alist' as second argument which doesn't make any sense.
> I now pass it the ACTION argument of `display-buffer' instead and tried
> to document this in the same revision as above.

Looks ok to me, the code as well as the doc.


Thanks,

Michael.





      reply	other threads:[~2012-11-18  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-10 19:18 bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented Michael Heerdegen
2012-11-10 19:42 ` Michael Heerdegen
2012-11-16 15:33   ` martin rudalics
2012-11-18  1:02     ` Michael Heerdegen
2012-11-13 13:50 ` martin rudalics
2012-11-16 15:32 ` martin rudalics
2012-11-18  1:00   ` Michael Heerdegen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876253u3ll.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=12854@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).