unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: 15200@debbugs.gnu.org
Subject: bug#15200: isearch-other-meta-char and shift
Date: Tue, 27 Aug 2013 19:28:22 +0300	[thread overview]
Message-ID: <8761urkssh.fsf@mail.jurta.org> (raw)

There is a problem in `isearch-other-meta-char' with shifted characters.
Typing <S-kp-0> exits Isearch instead of adding 0 to the search string.

A possible fix is to handle shifted kp-numbers like
shifted control characters are handled in the second
`cond' branch of `isearch-other-meta-char':

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2013-07-05 20:15:32 +0000
+++ lisp/isearch.el	2013-08-27 16:27:45 +0000
@@ -2550,6 +2606,16 @@ (defun isearch-other-meta-char (&optiona
 		    (lookup-key local-function-key-map key)))
 	     (while keylist
 	       (setq key (car keylist))
+	       ;; Handle an undefined shifted printing character
+	       ;; by downshifting it if that makes it printing.
+	       ;; (As read-key-sequence would normally do,
+	       ;; if we didn't have a default definition.)
+	       (if (and (integerp key)
+			(memq 'shift (event-modifiers key))
+			(>= key (+ ?\s (- ?\S-a ?a)))
+			(/= key (+ 127 (- ?\S-a ?a)))
+			(<  key (+ 256 (- ?\S-a ?a))))
+		   (setq key (- key (- ?\S-a ?a))))
 	       ;; If KEY is a printing char, we handle it here
 	       ;; directly to avoid the input method and keyboard
 	       ;; coding system translating it.






             reply	other threads:[~2013-08-27 16:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 16:28 Juri Linkov [this message]
2013-08-27 16:45 ` bug#15200: isearch-other-meta-char and shift Juri Linkov
2013-08-28  0:27   ` Stefan Monnier
2013-08-28 16:42     ` Juri Linkov
2013-08-28 18:33       ` Stefan Monnier
2013-08-29  6:49         ` Juri Linkov
2013-08-29 12:30           ` Stefan Monnier
2013-09-01 18:45             ` Juri Linkov
2013-09-03  2:12               ` Stefan Monnier
2013-09-03  2:22                 ` Drew Adams
2013-09-16 22:09                 ` Juri Linkov
2013-09-17  1:21                   ` Stefan Monnier
2013-09-17  2:19                   ` Stefan Monnier
2013-10-07 23:35                     ` Juri Linkov
2013-10-08  3:07                       ` Stefan Monnier
2013-10-08 23:29                         ` Juri Linkov
2013-10-09  2:43                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761urkssh.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=15200@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).