From: trentbuck@gmail.com (Trent W. Buck)
To: 15504@debbugs.gnu.org
Subject: bug#15504: 24.3; find-dired's numerous prompts are inflexible and annoying
Date: Wed, 02 Oct 2013 11:45:16 +1000 [thread overview]
Message-ID: <8761tg1m4z.fsf@gmail.com> (raw)
I prefer to do M-x grep RET and then type something complicated like
grep -r --include '*.c' --exclude-dir .git . -e foo -e bar
...rather than M-x rgrep which has lots of stupid prompts that then get
stuck together in a fixed kind of way.
In the same vein, I hate M-x find dired RET multiple prompts. For a few
years I've been using a munged up replacement that just asks for a
single command, and runs it (below). The history handling is a bit
buggered, and it breaks the existing multi-prompt style (presumably some
people prefer it).
Daniel Colascione liked my approach and asked me to publish it,
(presumably) so it can be cleaned up and pushed into Emacs proper.
I don't care enough to do that work myself, but I'm happy to talk to
anyone who does. I've already done the copyright assignment dance.
PS: find -ls's output is actually crap, because the entries don't line
up properly and files with spaces become "foo\ bar" which dired mode
doesn't like, so I generally end up doing "find -exec ls -lidsh {} +".
\f
(setq
find-ls-option ; http://emacsbugs.donarmstrong.com/4403
(let ((help (shell-command-to-string (format "%s --help" find-program))))
(if (string-match " -ls\\>" help)
'("-ls" . "-lids")
(if (string-match "{} \\+" help)
'("-exec ls -ldh {} +" . "-ldh")
'("-exec ls -ldh {} \\;" . "-ldh")))))
;;; Guerilla patch -- redefine FIND-DIRED to act less like RGREP and more like
;;; GREP. That is, prompt for an arbitrary command instead of "helpfully"
;;; constructing a command from an inflexible series of prompts. Defaults to
;;; "find -ls"; "find -exec ls {} +" is also possible to e.g. sort by file size.
(eval-after-load "dired"
'(eval-after-load "find-dired"
'(progn
(defvar find-command/twb (concat find-program " " (car find-ls-option)))
(defvar find-command-history/twb nil)
(defun find-dired (command)
"Like find-dired, but let me just WRITE the command instead of
trying to construct it for me. Cf. `grep' vs. `rgrep'."
(interactive (list (read-string "Run find: " find-command/twb '(find-command-history/twb . 1))))
(let ((dired-buffers dired-buffers)
(dir default-directory))
(switch-to-buffer (get-buffer-create "*Find*"))
(setq default-directory dir)
;; See if there's still a `find' running, and offer to kill
;; it first, if it is.
(let ((find (get-buffer-process (current-buffer))))
(when find
(if (or (not (eq (process-status find) 'run))
(yes-or-no-p "A `find' process is running; kill it? "))
(condition-case nil
(progn
(interrupt-process find)
(sit-for 1)
(delete-process find))
(error nil))
(error "Cannot have two processes in `%s' at once" (buffer-name)))))
(widen)
(kill-all-local-variables)
(setq buffer-read-only nil)
(erase-buffer)
(setq find-command command) ; save for next interactive call
;; Start the find process.
(shell-command (concat command "&") (current-buffer))
;; The next statement will bomb in classic dired (no optional arg allowed)
(dired-mode default-directory (cdr find-ls-option))
(let ((map (make-sparse-keymap)))
(set-keymap-parent map (current-local-map))
(define-key map "\C-c\C-k" 'kill-find)
(use-local-map map))
(make-local-variable 'dired-sort-inhibit)
(setq dired-sort-inhibit t)
(set (make-local-variable 'revert-buffer-function)
`(lambda (ignore-auto noconfirm)
(find-dired ,find-command)))
;; Set subdir-alist so that Tree Dired will work:
(if (fboundp 'dired-simple-subdir-alist)
;; will work even with nested dired format (dired-nstd.el,v 1.15
;; and later)
(dired-simple-subdir-alist)
;; else we have an ancient tree dired (or classic dired, where
;; this does no harm)
(set (make-local-variable 'dired-subdir-alist)
(list (cons default-directory (point-min-marker)))))
(set (make-local-variable 'dired-subdir-switches) find-ls-subdir-switches)
(setq buffer-read-only nil)
;; Subdir headlerline must come first because the first marker in
;; subdir-alist points there.
(insert " " default-directory ":\n")
;; Make second line a ``find'' line in analogy to the ``total'' or
;; ``wildcard'' line.
(insert " " command "\n")
(setq buffer-read-only t)
(let ((proc (get-buffer-process (current-buffer))))
(set-process-filter proc (function find-dired-filter))
(set-process-sentinel proc (function find-dired-sentinel))
;; Initialize the process marker; it is used by the filter.
(move-marker (process-mark proc) 1 (current-buffer)))
(setq mode-line-process '(":%s")))))))
\f
In GNU Emacs 24.3.1 (armv7l-unknown-linux-gnueabi)
of 2013-03-15 on elba
System Description: Ubuntu 11.10
Configured using:
`configure '--without-x' '--without-sound' '--without-all'
'--with-x-toolkit=no' '--with-xpm=no' '--with-gif=no' '--with-jpeg=no'
'--with-tiff=no' '--with-png=no' '--with-dbus=no' '--with-gsettings=no'
'--with-gnutls=no' '--prefix=/home/twb/opt/emacs-24.3''
next reply other threads:[~2013-10-02 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 1:45 Trent W. Buck [this message]
2013-10-04 4:16 ` bug#15504: 24.3; find-dired's numerous prompts are inflexible and annoying Kevin Rodgers
2021-05-30 5:55 ` Lars Ingebrigtsen
2021-05-30 11:41 ` Trent W. Buck
2021-05-30 12:30 ` Michael Heerdegen
2021-05-30 14:09 ` Trent W. Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761tg1m4z.fsf@gmail.com \
--to=trentbuck@gmail.com \
--cc=15504@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).