From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16078: Extensive docs and tests for `ruby-forward-string' (PATCH) Date: Sat, 07 Dec 2013 05:22:55 +0200 Message-ID: <8761r1wdio.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386386657 26157 80.91.229.3 (7 Dec 2013 03:24:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Dec 2013 03:24:17 +0000 (UTC) Cc: 16078@debbugs.gnu.org To: Cameron Desautels Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 07 04:24:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vp8VA-0005rZ-Td for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2013 04:24:21 +0100 Original-Received: from localhost ([::1]:34401 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8VA-0004xT-CC for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2013 22:24:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8Uz-0004xA-UE for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:24:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp8Us-0006Te-Gj for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:24:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp8Us-0006Ta-DD for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vp8Ur-0000sx-Vn for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2013 22:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2013 03:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16078 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16078-submit@debbugs.gnu.org id=B16078.13863865833313 (code B ref 16078); Sat, 07 Dec 2013 03:24:01 +0000 Original-Received: (at 16078) by debbugs.gnu.org; 7 Dec 2013 03:23:03 +0000 Original-Received: from localhost ([127.0.0.1]:35273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vp8Tu-0000rN-Kw for submit@debbugs.gnu.org; Fri, 06 Dec 2013 22:23:02 -0500 Original-Received: from mail-ea0-f171.google.com ([209.85.215.171]:39506) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vp8Tr-0000qr-Sy for 16078@debbugs.gnu.org; Fri, 06 Dec 2013 22:23:00 -0500 Original-Received: by mail-ea0-f171.google.com with SMTP id h10so609889eak.16 for <16078@debbugs.gnu.org>; Fri, 06 Dec 2013 19:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=yZDR6x18kZad1KIqCmJvZjb30iOP+BOR1b5OZ6h5FD8=; b=bWSxmCghnj4P9Gzrg5cYnHmFHO5VG/7/FZRmd6RgMk0RrrAXYBlN3EU9BD5jJBRivB 4kMG7nRcPgAJrjO65YNv5jQAsm/0UYb1yzNpb4SG8v5gnhrrOiIxpEF/+m6r0E0FIgeu h7rIV6k5aAmLbX6O/nZpQHFCPWX5Ha4GadCRbGFqTx0MrZCKmXmIW51tXkJ8EAPx6lkZ HmMrxPVwLn+ntLpr+y5NSSSmRVKR6LAUOK6fzc5F7QKH3P1uAlyO+ZwMsU8XuivtB2b1 McCYoJtcENwKRoakllHdRSy1nUOfc7xwVtnrNTwtd3ttuMz2HX8WjmBPV40ixcodZNv6 UAgQ== X-Received: by 10.15.53.193 with SMTP id r41mr4906930eew.2.1386386579204; Fri, 06 Dec 2013 19:22:59 -0800 (PST) Original-Received: from axl ([62.228.136.233]) by mx.google.com with ESMTPSA id 4sm1977032eed.14.2013.12.06.19.22.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Dec 2013 19:22:58 -0800 (PST) In-Reply-To: (Cameron Desautels's message of "Fri, 6 Dec 2013 11:15:52 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81576 Archived-At: Hi Cameron, Cameron Desautels writes: > The attached patch adds extensive documentation and tests to the > `ruby-forward-string' function. > > This may seem an odd function to document thoroughly, but I spent > quite a while wrapping my head around the exact behavior and I want to > spare the next person. It also underlies some important parsing > functionality in ruby-mode. Thank you for your effort, but it probably would've been more valuable a few months ago or earlier. The ruby-mode that will be released with Emacs 24.4 has switched to using SMIE for indentation and sexp navigation by default, and it leaves quite a bit of the old, undocumented code unused. Whatever code examples and functionality didn't work for you, have you tried them with the current trunk? We can still use the two patches, of course, since the old indentation engine can still be enabled with `(setq ruby-use-smie nil)', but they exceed the 15 line limit and will require copyright assignment (AFAIR, we do require those even for test code). Have you signed, or are you willing to sign the copyright assignment papers?