unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Cameron Desautels <camdez@gmail.com>
Cc: 16078@debbugs.gnu.org
Subject: bug#16078: Extensive docs and tests for `ruby-forward-string' (PATCH)
Date: Sat, 07 Dec 2013 05:22:55 +0200	[thread overview]
Message-ID: <8761r1wdio.fsf@yandex.ru> (raw)
In-Reply-To: <CALtQdcmQjKS-V5umK4vLAJJDtOgcokKq26fyCGjyHx=65wR8xQ@mail.gmail.com> (Cameron Desautels's message of "Fri, 6 Dec 2013 11:15:52 -0600")

Hi Cameron,

Cameron Desautels <camdez@gmail.com> writes:

> The attached patch adds extensive documentation and tests to the
> `ruby-forward-string' function.
>
> This may seem an odd function to document thoroughly, but I spent
> quite a while wrapping my head around the exact behavior and I want to
> spare the next person.  It also underlies some important parsing
> functionality in ruby-mode.

Thank you for your effort, but it probably would've been more valuable a
few months ago or earlier.  The ruby-mode that will be released with
Emacs 24.4 has switched to using SMIE for indentation and sexp
navigation by default, and it leaves quite a bit of the old,
undocumented code unused.

Whatever code examples and functionality didn't work for you, have you
tried them with the current trunk?

We can still use the two patches, of course, since the old indentation
engine can still be enabled with `(setq ruby-use-smie nil)', but they
exceed the 15 line limit and will require copyright assignment (AFAIR,
we do require those even for test code).  Have you signed, or are you
willing to sign the copyright assignment papers?





  reply	other threads:[~2013-12-07  3:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 17:15 bug#16078: Extensive docs and tests for `ruby-forward-string' (PATCH) Cameron Desautels
2013-12-07  3:22 ` Dmitry Gutov [this message]
2013-12-08  2:29   ` Cameron Desautels
2013-12-09  4:07     ` Dmitry Gutov
2013-12-11 22:48       ` Cameron Desautels
2013-12-15  3:36         ` Dmitry Gutov
2015-11-15 14:55           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761r1wdio.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=16078@debbugs.gnu.org \
    --cc=camdez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).