unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16808@debbugs.gnu.org, Andreas Schwab <schwab@suse.de>,
	Nicolas Richard <theonewiththeevillook@yahoo.fr>
Subject: bug#16808: 24.3.50; an error when completing M-x ... commands.
Date: Mon, 24 Feb 2014 16:03:13 +0100	[thread overview]
Message-ID: <8761o4eeoe.fsf@yahoo.fr> (raw)
In-Reply-To: <jwv7g8rgonf.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 19 Feb 2014 09:31:28 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> -	  (when (and (= 1 (length comps) (consp (car comps))))
>>> +	  (when (and (= 1 (length comps)) (consp (car comps)))
>> (= 1 (length comps)) would be better written as (not (cdr comps)) in
>> this context.
>
> Both look good, please install,

FWIW I'm unable to do that. If there's anything I can do to make
someone's life easier for installing I'll be happy to do so. Meanwhile,
here's an updated patch:

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index edc4c95..7f98005 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1371,7 +1371,7 @@ appear to be a match."
 				   (concat before ext after)
 				   table predicate (1+ point) md))
 				exts))))
-	  (when (and (= 1 (length comps) (consp (car comps))))
+	  (when (and (null (cdr comps)) (consp (car comps)))
 	    (setq comp (car comps)))))
 
       ;; Completing a single word is actually more difficult than completing
@@ -1451,7 +1451,7 @@ Return nil if there is no valid completion, else t."
         (minibuffer-completion-predicate predicate))
     (pcase (completion--do-completion beg end
                                       #'completion--try-word-completion)
-    (#b000 nil)
+      (#b000 nil)
       (_     t))))
 
 (defface completions-annotations '((t :inherit italic))


-- 
Nico.





  reply	other threads:[~2014-02-24 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 11:23 bug#16808: 24.3.50; an error when completing M-x ... commands Nicolas Richard
2014-02-19 11:40 ` Andreas Schwab
2014-02-19 14:31   ` Stefan Monnier
2014-02-24 15:03     ` Nicolas Richard [this message]
2014-02-24 15:42       ` Juanma Barranquero
2014-02-19 15:03   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761o4eeoe.fsf@yahoo.fr \
    --to=theonewiththeevillook@yahoo.fr \
    --cc=16808@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).