unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: oscarfv@telefonica.net (Óscar Fuentes)
To: 18699@debbugs.gnu.org
Subject: bug#18699: 25.0.50; Windows 7: Odd length text property list
Date: Mon, 13 Oct 2014 13:46:22 +0200	[thread overview]
Message-ID: <8761fojiml.fsf@telefonica.net> (raw)
In-Reply-To: <87eguclr91.fsf@telefonica.net>

The MinGW-w64 guys say that _W64 is not the rigth way of checking that
we are targeting Windows 64. _WIN64 is.

http://sourceforge.net/p/mingw-w64/mailman/message/32925577/

AFAIU the fact that we are using _W64 for detecting MinGW-w64 (on both
32 and 64 bit variants) is also wrong. _W64 is a MS thing and not
specific to MinGW-w64, as explained on the StackOverflow question linked
from the above message. It just happens that MinGW does not define it.

The right way to detect MinGW-w64 is to test for __MINGW64_VERSION_MAJOR
*after* including some C runtime header or _mingw.h, because it is not a
preprocessor predefined macro. It is explained here:

http://sourceforge.net/p/mingw-w64/discussion/723798/thread/ea355c1f/#d4db

I propose to fix the ALIGN_STACK issue by replacing _W64 with _WIN64 and
later fix the places where _W64 is used for detecting MinGW-w64 with the
right method.

Eli, can you take care of the ALIGN_STACK fix? I'll send a patch for the
rest of _W64 cases, if nobody beats me to it.





  parent reply	other threads:[~2014-10-13 11:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13  0:58 bug#18699: 25.0.50; Windows 7: Odd length text property list Óscar Fuentes
     [not found] ` <handler.18699.B.141316196215131.ack@debbugs.gnu.org>
2014-10-13  2:02   ` Óscar Fuentes
2014-10-13  5:31     ` Eli Zaretskii
2014-10-13  6:14       ` Eli Zaretskii
2014-10-13 10:27         ` Óscar Fuentes
2014-10-13 11:37           ` Eli Zaretskii
2014-10-13 11:46         ` Óscar Fuentes [this message]
2014-10-13 12:49           ` Eli Zaretskii
2014-10-13 13:57             ` Óscar Fuentes
2014-10-13 19:07               ` Eli Zaretskii
2014-10-13 19:14                 ` Ken Brown
2014-10-13 19:39                   ` Óscar Fuentes
2014-10-13 20:25                     ` Eli Zaretskii
2014-10-13 20:35                       ` Óscar Fuentes
2014-10-14  6:09                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761fojiml.fsf@telefonica.net \
    --to=oscarfv@telefonica.net \
    --cc=18699@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).