From: Ted Zlatanov <tzz@lifelogs.com>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 17958@debbugs.gnu.org
Subject: bug#17958: SHR: base handling broken (shr-parse-base, shr-expand-url)
Date: Tue, 04 Nov 2014 11:44:07 -0500 [thread overview]
Message-ID: <8761eu7w6g.fsf@lifelogs.com> (raw)
In-Reply-To: <871tsirjmb.fsf@violet.siamics.net> (Ivan Shmakov's message of "Thu, 14 Aug 2014 18:50:20 +0000")
On Thu, 14 Aug 2014 18:50:20 +0000 Ivan Shmakov <ivan@siamics.net> wrote:
>> Thus, I suggest changing shr-expand-url to return not the 0th element
>> of the (parsed) ‘base’ (see below), but the 3rd.
...
IS> With the patch MIMEd (which also fixes the issue described in my
IS> initial bug report), it instead gives what I deem to be the
IS> correct result:
IS> (let ((shr-base (shr-parse-base "http://example.org/")))
IS> (shr-tag-base '((:href . "/relative")))
IS> shr-base)
IS> ;; ⇒
IS> ("http://example.org" "/" "http" "http://example.org/relative")
This seems reasonable to me as far as usability but Lars will have to
review the patch for correctness.
Ted
next prev parent reply other threads:[~2014-11-04 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 18:45 bug#17958: eww-submit mishandles the POST method, no action forms Ivan Shmakov
2014-08-14 18:50 ` bug#17958: SHR: base handling broken (shr-parse-base, shr-expand-url) Ivan Shmakov
2014-11-04 16:44 ` Ted Zlatanov [this message]
2014-11-13 18:41 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761eu7w6g.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=17958@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).