From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Thu, 10 Sep 2015 21:22:02 +0200 Message-ID: <87613inkpx.fsf@gnu.org> References: <87y4gh47sr.fsf@gnu.org> <83k2s07vaf.fsf@gnu.org> <87fv2ovlcr.fsf@gmx.de> <83613k7owe.fsf@gnu.org> <87si6og17z.fsf@gnu.org> <877fnzv4r6.fsf@gmx.de> <87egi7o1s1.fsf@gnu.org> <871te7tk9i.fsf@gnu.org> <87oahatt4p.fsf@gmx.de> <87a8sunve8.fsf@gnu.org> <87si6mi2oy.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441913018 26349 80.91.229.3 (10 Sep 2015 19:23:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Sep 2015 19:23:38 +0000 (UTC) Cc: 21435@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 10 21:23:27 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Za7RF-0004g4-Ao for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Sep 2015 21:23:17 +0200 Original-Received: from localhost ([::1]:51436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za7R9-0003OK-LO for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Sep 2015 15:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za7R4-0003Jr-0I for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2015 15:23:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za7R0-0002iW-TW for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2015 15:23:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za7R0-0002iS-QQ for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2015 15:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Za7R0-0005Ll-II for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2015 15:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2015 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.144191292820490 (code B ref 21435); Thu, 10 Sep 2015 19:23:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 10 Sep 2015 19:22:08 +0000 Original-Received: from localhost ([127.0.0.1]:55612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Za7Q8-0005KQ-7U for submit@debbugs.gnu.org; Thu, 10 Sep 2015 15:22:08 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Za7Q6-0005KH-4U for 21435@debbugs.gnu.org; Thu, 10 Sep 2015 15:22:06 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CE896203DD for <21435@debbugs.gnu.org>; Thu, 10 Sep 2015 15:22:05 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Thu, 10 Sep 2015 15:22:05 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=RdS+PhnGyEJODHE3JP8u6m6LGm0=; b=WWEwn 4hCHnWYo0uGoBe+L6KRmInnyMj8WNEHoDrKpJ0bkWYqdBb1+ptPaItUnc3GKu3Nt c6SwtzzBwD/4UFGrS0xjbFpLkQt2/kumS2aXWQODvSNfWxcrdolG9JyLIhbfX8nz pJTiWkU1aPpgmYJRQ2TUpwiwRXAGfrT+hRHjJs= X-Sasl-enc: yN3BYjLwAgYoUyu+s3sfNQLlmmxyrVOHCaPPKkbTM+dr 1441912925 Original-Received: from thinkpad-t440p (unknown [2.160.5.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A166C00285; Thu, 10 Sep 2015 15:22:04 -0400 (EDT) In-Reply-To: <87si6mi2oy.fsf@gmx.de> (Michael Albinus's message of "Thu, 10 Sep 2015 19:50:21 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106389 Archived-At: Michael Albinus writes: >> I've added a new macro to the tests now which lets you do things this >> way: >> >> ;; Check creation, change, and deletion. >> (file-notify--test-with-events >> 3 3 (lambda (events) >> (should (equal '(created changed deleted) >> (mapcar #'cadr events)))) >> (write-region >> "any text" nil file-notify--test-tmpfile nil 'no-message) >> (delete-file file-notify--test-tmpfile)) >> >> This means we're waiting for 3 events for at most 3 seconds, and then >> apply the lambda to the received events. The rest is the code which >> causes the events to be emitted. > > That's good, yes. Please add a docstring to that macro (boring, I > know, but it will help other people like Eli and me). Done. > One point: you don't call any longer `read-event'. I believe it still > makes sense; IIRC I did it because sometimes you must trigger Emacs to > check all its file descriptors for new events. I still do. That macro uses `file-notify--wait-for-events' to wait until all N events have arrived before calling the ASSERT-FN. >> Another thing: the remote tests, especially the test03-autorevert >> one, take really, really long (maybe 30 seconds). I saw that this >> uses some mock TRAMP method which suggests it is a mockup connection >> which can probably simulate a fast or a slow connection. If so, I'd >> prefer to have a reasonably fast one so that I don't try to avoid >> running all tests frequently. > > Well, the mockup method is a silly one and it even doesn't require a > remote connection, so it shall be faster than any other Tramp method. > And I do not experience serious delays when testing. Hm, then I wonder what causes these extreme delays here. The remote autorevert test really takes at least 20 seconds here. But I have no issues using TRAMP with its ssh method for accessing really remote files... > You could alway skip all the remote tests. As your tester, I obviously want to run all tests. :-) Bye, Tassilo