unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Łukasz Stelmach" <stlman@poczta.fm>
Cc: 22611@debbugs.gnu.org
Subject: bug#22611: [PATCH] Call ps-encode-header-string-function for plain strings too
Date: Tue, 23 Feb 2016 14:55:48 +1100	[thread overview]
Message-ID: <8760xg3wsb.fsf@gnus.org> (raw)
In-Reply-To: <1455052071-4582-1-git-send-email-stlman@poczta.fm> ("Łukasz Stelmach"'s message of "Tue, 9 Feb 2016 22:07:51 +0100")

Łukasz Stelmach <stlman@poczta.fm> writes:

> The function needs to be called for plain strings too to ensure
> the BitmapDict contains required characters and Unicode characters
> in the headers are printed properly.
> ---
>  lisp/ps-print.el | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/ps-print.el b/lisp/ps-print.el
> index 7333709..999398e 100644
> --- a/lisp/ps-print.el
> +++ b/lisp/ps-print.el
> @@ -4761,7 +4761,11 @@ page-height == ((floor print-height ((th + ls) * zh)) * ((th + ls) * zh)) - th
>     ;; Literal strings should be output as is -- the string must contain its own
>     ;; PS string delimiters, '(' and ')', if necessary.
>     ((stringp content)
> -    (ps-output content))
> +    (if (functionp ps-encode-header-string-function)
> +		(dolist (l (funcall ps-encode-header-string-function
> +				    content fonttag))
> +	  (ps-output l))
> +    (ps-output content)))

I'm not very familiar with ps-print.el, but it looks good to me, so I've
applied it to emacs-25.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2016-02-23  3:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 21:03 bug#22611: 24.4; ps-print.el generates invalid files Łukasz Stelmach
2016-02-09 21:07 ` bug#22611: [PATCH] Call ps-encode-header-string-function for plain strings too Łukasz Stelmach
2016-02-23  3:55   ` Lars Ingebrigtsen [this message]
2016-02-10  8:11 ` bug#22611: No dolist required Łukasz Stelmach
2016-02-11  9:06   ` Łukasz Stelmach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760xg3wsb.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=22611@debbugs.gnu.org \
    --cc=stlman@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).