From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 18110@debbugs.gnu.org
Subject: bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs
Date: Tue, 23 Feb 2016 23:30:02 +1100 [thread overview]
Message-ID: <8760xfobhx.fsf@gnus.org> (raw)
In-Reply-To: <87ppgtt95n.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 25 Jul 2014 14:34:28 -0700")
Dima Kogan <dima@secretsauce.net> writes:
> When looking at expanded git logs with vc-print-root-log (C-x v L,
> then <enter> by default), emacs was stripping out all leading
> whitespace from git logs. This was done by an (indent-region)
> call. This patch fixes this issue by removing this call. It might be
> good to remove a constant amount of whitespace from the beginning of
> each log line, but it's not obvious that matters, and it seems more
> trouble than it's worth.
[...]
> - (unless (eobp)
> - ;; Indent the expanded log entry.
> - (indent-region (point-min) (point-max) 2)
> - (buffer-string))))
> + (unless (eobp) (buffer-string))))
It seems like a deliberate design choice... I have no idea whether it's
a good one, though. Anybody?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-23 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 21:34 bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs Dima Kogan
2014-07-26 3:12 ` bug#18110: clarification Dima Kogan
2016-02-23 12:30 ` Lars Ingebrigtsen [this message]
2016-02-24 0:25 ` bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs Dmitry Gutov
2016-02-28 3:13 ` Dima Kogan
2016-02-28 4:48 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760xfobhx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=18110@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).