From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#22534: File notify broken on Windows Date: Tue, 08 Mar 2016 08:44:30 +0100 Message-ID: <8760wxv2g1.fsf@gmx.de> References: <83egcbun0o.fsf@gnu.org> <8360xnukzx.fsf@gnu.org> <83a8mvprbg.fsf@gnu.org> <83oabbnxvs.fsf@gnu.org> <83io1glmkg.fsf@gnu.org> <87y4abtwhq.fsf@gmx.de> <8337sjjsql.fsf@gnu.org> <87ziuc3gay.fsf@gmx.de> <83twkkwxdi.fsf@gnu.org> <83mvqcwa2v.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457423123 18566 80.91.229.3 (8 Mar 2016 07:45:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 07:45:23 +0000 (UTC) Cc: 22534@debbugs.gnu.org To: Fabrice Popineau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 08 08:45:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adCKL-0003fA-K9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 08:45:09 +0100 Original-Received: from localhost ([::1]:32772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCKL-0002sg-5C for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 02:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCKI-0002rR-AM for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 02:45:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adCKE-0006xS-9a for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 02:45:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adCKE-0006xO-6N for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 02:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adCKD-00027h-Sg for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 02:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Mar 2016 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14574230808121 (code B ref 22534); Tue, 08 Mar 2016 07:45:01 +0000 Original-Received: (at 22534) by debbugs.gnu.org; 8 Mar 2016 07:44:40 +0000 Original-Received: from localhost ([127.0.0.1]:38583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adCJs-00026v-BH for submit@debbugs.gnu.org; Tue, 08 Mar 2016 02:44:40 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:54712) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adCJq-00026j-Rg for 22534@debbugs.gnu.org; Tue, 08 Mar 2016 02:44:39 -0500 Original-Received: from detlef.gmx.de ([87.146.56.63]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MMCFR-1aVnv833sL-007zIK; Tue, 08 Mar 2016 08:44:31 +0100 In-Reply-To: (Fabrice Popineau's message of "Tue, 8 Mar 2016 06:45:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:b0TPWhi/Z/hUGTew3D94XJBOjt5k2cRXzvv3VfHtCROW2iQCWsZ lXN4qGNN76xqFyPM7Yj/yFxJmHYmRWqEQ9lmtNpGrhQFsmQ7Eo104PFEG90tM0pkT3vi45N PBaXhKXO4UCSu0avQMxdoj7Pdx4AgfcExeJ/udH9T1yv4BFpz8fl9EzdJkwq3UwL/wM48nk QQkba2o401B/W/bd/0PCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CeEN0QjX+8o=:iggLrHO90MFD+SqZzKmhn/ D7RfJjR3keD7W6aS96HghbDowvXGeRwgtchcMzyPlhAeB3MV9JwJXBI35BqF8VLybFPB/dxUc ocRS9nYG3pd6Pqic3kbRNqy+aoo3K0fUFyQV2FRNUGxtwzw5gnpbjbDbBLNnyq5zhKi2H7ym2 wkNpVhd+6Bui9I6iMr1NHnHGzzKTMU+OOCLMYoeuhPY6aCgjwS2MZCGvzotm+hmcL0SvnRfjK 8G6/nnRHYNdTuOCzYkgpLRfA0DN34bY+qR33e+0yt4KYSC510+KrLm39HgsjZKV6X8u10hwak kkdHe2Czb2BfDGsl68sjFSjS/UrZpSHbcIpjRdl2COo3FL0CHxOlxjbQ3DTXmhHUfb6VThm1J 8dP9CzGmZ1nrDZlvOPGyE1iRnHP4BMupgsF3cOI2isD1KeH+WyMbkuAiBxgtAVfBBcNBPf6Q+ 14l2b5WYjh46i9wZ5uWOHAscplEEZB7qEyzueIZqPxyfXDNJX9QdcHu6ulrhHgXdEkxgkO/l1 QcRFta1XexYUh7XI+W07RG9zXjU6bJERMEDMIM47rlb3ugWDdRE4e2DHSb2Di9va+hPw4HgBP 1MJkX5OBLCCOOsxMa0SSc67yULo3cJJO/WcY6CENs3qrFwntMDhWe0KUhu3AlI24allU6A/RQ r9ypch6s+cYcByXS9tM8x2p+C9TDuGE1z/aNs8vWOiTV7jmv3dBKwnY6C6yr2GwlApzmSscH8 bYiCsyXb4CrYd68eOoKBlXHlWO6oTPEGYu+C1c/JKsR33pQfDowhU6xTqMN/x8ZTdO/1r2eR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114562 Archived-At: Fabrice Popineau writes: [Added 22534@debbugs.gnu.org to Cc] > Ok, patch attached. > > The remaining DebPrint() should be left in case of problems. > They all indicate some sort of error (I think). > > I have a disagreement on this test: > > diff --git a/test/lisp/filenotify-tests.el > b/test/lisp/filenotify-tests.el > index bc64f86..20e01fc 100644 > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -530,7 +530,7 @@ file-notify--test-with-events > ;; w32notify does not distinguish between `changed' and > ;; `attribute-changed'. > ((string-equal (file-notify--test-library) "w32notify") > - '(changed changed changed changed)) > + '(changed changed)) > ;; For kqueue and in the remote case, `write-region' > ;; raises also an `attribute-changed' event. > ((or (string-equal (file-notify--test-library) "kqueue") > > At least on Windows 10, I get only 2 notifications and not 4. > Could you or Michael check about it? As soon as I get a compiled Emacs for w32, including your patch, I'll test it. It will be on a Windows 7 machine, hope there are no differences to your test. > Best regards, Best regards, Michael.