From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results Date: Mon, 09 May 2016 23:01:49 +0300 Organization: LINKOV.NET Message-ID: <8760unxaoi.fsf@mail.linkov.net> References: <86d1owl682.fsf@yandex.ru> <87inyoxpz8.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1462824216 6706 80.91.229.3 (9 May 2016 20:03:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 May 2016 20:03:36 +0000 (UTC) Cc: 23484@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 09 22:03:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1azrOd-0003LE-R6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2016 22:03:16 +0200 Original-Received: from localhost ([::1]:43197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azrOc-0000Qt-Jw for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2016 16:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azrOX-0000Lc-GZ for bug-gnu-emacs@gnu.org; Mon, 09 May 2016 16:03:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azrOQ-0004de-OO for bug-gnu-emacs@gnu.org; Mon, 09 May 2016 16:03:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azrOQ-0004dX-MG for bug-gnu-emacs@gnu.org; Mon, 09 May 2016 16:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1azrOQ-00039u-FO for bug-gnu-emacs@gnu.org; Mon, 09 May 2016 16:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2016 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23484-submit@debbugs.gnu.org id=B23484.146282417712129 (code B ref 23484); Mon, 09 May 2016 20:03:02 +0000 Original-Received: (at 23484) by debbugs.gnu.org; 9 May 2016 20:02:57 +0000 Original-Received: from localhost ([127.0.0.1]:44725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azrOL-00039Z-Ek for submit@debbugs.gnu.org; Mon, 09 May 2016 16:02:57 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:38679 helo=homiemail-a76.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azrOG-00039O-Ra for 23484@debbugs.gnu.org; Mon, 09 May 2016 16:02:55 -0400 Original-Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id C8BDF45807B; Mon, 9 May 2016 13:02:51 -0700 (PDT) Original-Received: from localhost.linkov.net (62.65.224.13.cable.starman.ee [62.65.224.13]) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPA id 0C536458079; Mon, 9 May 2016 13:02:50 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Sun, 8 May 2016 23:26:19 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118037 Archived-At: >> Then maybe there is a better way to achieve the same. > > Maybe there is, but I don't know it. > >> You don't need isearch-filter-predicate when doing undo >> because a previous replacement already checked it, no? > > Not sure. It's possible the problem is caused by FROM being `.*'. The > post-undo code initiates new searches at the positions of the previous > matches using `looking-at'. Why not using an original search string instead of =E2=80=98.*=E2=80=99 t= hus avoiding tricks with isearch-filter-predicate/replace-re-search-function? perform-replace will have no problem finding the same matches as found by xref.