* bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link
@ 2016-06-11 0:05 Dima Kogan
2016-06-11 11:37 ` Rasmus
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dima Kogan @ 2016-06-11 0:05 UTC (permalink / raw)
To: 23745
Hi. Consider this org-mode file:
=====================
* aaaa
bbbbb
* cccc
[[aaaa]]
=====================
With the point at the [[aaaa]] link, I can visit the aaaa heading with
C-c C-o (org-open-at-point), and I can go back to where I was with the
org-specific C-c & (org-mark-ring-goto). But I should also be able to go
back with C-u C-SPC (effectively pop-to-mark-command), since that works
for inside-the-same-buffer jumps in all other emacs context, including
non-org ones. I suspect all we would need to do is to
(push-mark-command) before we jump in (org-open-at-point). Is this
simply forgotten, or was it omitted on purpose? If the former, I'll post
a patch.
dima
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link
2016-06-11 0:05 bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link Dima Kogan
@ 2016-06-11 11:37 ` Rasmus
2018-02-27 0:10 ` Nicolas Goaziou
[not found] ` <87tvu3xpfb.fsf@nicolasgoaziou.fr>
2 siblings, 0 replies; 4+ messages in thread
From: Rasmus @ 2016-06-11 11:37 UTC (permalink / raw)
To: 23745
Hi Dima,
Thanks for the report.
Dima Kogan <dima@secretsauce.net> writes:
> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.
I think you are right; your description of behavior would be consistent.
Note that once I click C-c & at "* aaaa" and thus return to the link
"[[aaaa]]" I can pop the mark to go back to "* aaaa" but the reverse is
not possible.
A fix for this would be appreciated.
Thanks,
Rasmus
--
Send from my Emacs
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link
2016-06-11 0:05 bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link Dima Kogan
2016-06-11 11:37 ` Rasmus
@ 2018-02-27 0:10 ` Nicolas Goaziou
[not found] ` <87tvu3xpfb.fsf@nicolasgoaziou.fr>
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2018-02-27 0:10 UTC (permalink / raw)
To: Dima Kogan; +Cc: 23745-done
Hello,
Dima Kogan <dima@secretsauce.net> writes:
> Hi. Consider this org-mode file:
>
> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.
Fixed.
Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the
latter should replace former, although navigation with Org dedicated
mark ring is still slightly easier (e.g., no distinction between global
and local rings).
Thank you.
Regards,
--
Nicolas Goaziou 0x80A93738
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <87tvu3xpfb.fsf@nicolasgoaziou.fr>]
end of thread, other threads:[~2018-02-27 2:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-11 0:05 bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link Dima Kogan
2016-06-11 11:37 ` Rasmus
2018-02-27 0:10 ` Nicolas Goaziou
[not found] ` <87tvu3xpfb.fsf@nicolasgoaziou.fr>
2018-02-27 2:12 ` bug#23745: [O] " Samuel Wales
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).