From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Date: Sun, 03 Jul 2016 10:39:05 +0100 Message-ID: <8760snkqme.fsf@russet.org.uk> References: <83h9cavdgj.fsf@gnu.org> <87poqyy2tc.fsf@metalevel.at> <87vb0qqrkz.fsf@russet.org.uk> <87h9c9zx75.fsf@metalevel.at> <834m89vmyv.fsf@gnu.org> <878txlsbdb.fsf@russet.org.uk> <87furtccdv.fsf@metalevel.at> <877fd5q9te.fsf@russet.org.uk> <83bn2gtruk.fsf@gnu.org> <87k2h37pvb.fsf@russet.org.uk> <834m87s8hl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467538825 17101 80.91.229.3 (3 Jul 2016 09:40:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2016 09:40:25 +0000 (UTC) Cc: 23871@debbugs.gnu.org, triska@metalevel.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 11:40:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJdsq-0005vL-Vq for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 11:40:13 +0200 Original-Received: from localhost ([::1]:41876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdsq-0000tY-1t for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 05:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdsk-0000s7-6j for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJdsg-0006t5-Ug for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:40:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdsg-0006t1-RU for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJdsg-0007Ms-EM for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2016 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23871-submit@debbugs.gnu.org id=B23871.146753875928265 (code B ref 23871); Sun, 03 Jul 2016 09:40:02 +0000 Original-Received: (at 23871) by debbugs.gnu.org; 3 Jul 2016 09:39:19 +0000 Original-Received: from localhost ([127.0.0.1]:35131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdrz-0007Lp-Ji for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:39:19 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:36842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdrx-0007La-8P for 23871@debbugs.gnu.org; Sun, 03 Jul 2016 05:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=QTW7+RW5uovLEIzmMxvWi9xdFBn8z8vQognW3LPvWa0=; b=aH3cz1m/DXN9gPnqF6yqynOth7 heebkDRCKiaU+nP3aIvEAEq2wwO6fwHO60ciXUBIX5iNKkVV9EmbEuWuqx4UiCGqtEdh9cXsnippT DbyIto6qFptN6yCoZYCeU1EKambIx5niN2ho9jNmvVNldnlrpuJPb706+DwtegTPG8p6/iVX0Pc5B mrG8USPK+glCwP8WNBnDa/Cf7XomEzC3SMgIRP8za0PuPRYzH34Sl/SeoINaNVqS2Rds24y6nXclY Y2sDVsEtUUtgrtOOFgC1j7b54Y0SO8WC1XGo/Maz+qAhPX0gtn/m1bx7cOXNKkohZ4r8Ua7OH/TDU PdkFlK1w==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:54398 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bJdrr-001d8B-8g; Sun, 03 Jul 2016 10:39:11 +0100 In-Reply-To: <834m87s8hl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Jul 2016 06:31:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120325 Archived-At: Eli Zaretskii writes: >> From: phillip.lord@russet.org.uk (Phillip Lord) >> Cc: triska@metalevel.at, 23871@debbugs.gnu.org >> Date: Sat, 02 Jul 2016 21:21:28 +0100 >> >> > The problem, AFAIU, is in point movements _during_ eval-defun: they >> > seem to not be recorded in buffer-undo-list. The undo list I get >> > after C-M-x is this: >> > >> > (nil (117 . 122) (t 22391 27551 0 0)) >> > >> >> So, I don't think this is a regression caused by my patch at all. It is >> an bug that has been there since I altered undo.c last year. >> >> The problem was caused because of undo only records point after a >> boundary (or the first element). I'd changed things during slightly when >> I update undo.c so that the timestamp list got added before checking >> whether I was at a boundary, hence blocking addition of the point >> restoration information. >> >> This is why I found the problem so erratic to replicate; it only occurs >> immediately the first change to a buffer. >> >> I believe the following patch addresses the issue. > > Seems like this is still not the final patch, so I guess we will need > to wait for the right one. Yes. I will try and investigate 23871 as soon as I can. > It should go to the emacs-25 branch, which probably means one more > pretest, sigh. Unfortunately, yes. It's a pity that I didn't 21722 when it came in. Phil