From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#24041: 25.1.50; xwidget + -nw mode gives segfault Date: Fri, 19 Aug 2016 11:36:30 -0700 Message-ID: <8760qwtxld.fsf@cochranmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471631841 31719 195.159.176.226 (19 Aug 2016 18:37:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Aug 2016 18:37:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24041@debbugs.gnu.org To: Shane Hansen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 19 20:37:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baofN-0007ze-70 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Aug 2016 20:37:17 +0200 Original-Received: from localhost ([::1]:58574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baofJ-0006yo-BW for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Aug 2016 14:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baofD-0006yi-8m for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 14:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baof8-0002kM-5h for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 14:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baof7-0002kC-S1 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1baof7-0000bg-O2 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2016 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Aug 2016 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24041-submit@debbugs.gnu.org id=B24041.14716317962297 (code B ref 24041); Fri, 19 Aug 2016 18:37:01 +0000 Original-Received: (at 24041) by debbugs.gnu.org; 19 Aug 2016 18:36:36 +0000 Original-Received: from localhost ([127.0.0.1]:34464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baoei-0000az-6Q for submit@debbugs.gnu.org; Fri, 19 Aug 2016 14:36:36 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:54262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baoeg-0000ap-Pw for 24041@debbugs.gnu.org; Fri, 19 Aug 2016 14:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=ai9QHTjLE72duiSyC34KIZn/904=; b=1KWN1 DXcL7brxoVz1AqTOIY0A4QdPjQo5tax0qwbjkyhgJylZQqd1Wjkmcv6PmmtChazB trHXq90haflGZpdcVpMTtqVJRVxTFfMZFdMu2TC2/uB8Pa6pXdVDyisbr+HoCOSy J18mAZteLgS8eH65jck4as3+DS7F4AmOAeACYL6mn7Y3LQyxtBWNRoALv/eKugAL mEWUtjGpoIKiDB/28pep+uPNJ+lAniB1szjWn/8lW9r1rF49n4Zi7CEcBnp4v9Gd J7Q0L/XNmdLiYOtGkw+OM2flK1wl/ei05sf43SyUnc+ZqXFhaLXWomcO/sCzI65I 96Nhojma4IvIo8qzA== Original-Received: (qmail 8367 invoked by uid 0); 19 Aug 2016 18:36:31 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=djusX83EOXqhULx/lq0KyH/xyF2ZDkzlS142wSi8/93T6BC9rQI7G1kjwRX0lqPBZml8KEkiY+1xoypTGmXpCQ==; Original-Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 19 Aug 2016 18:36:31 -0000 In-Reply-To: (Shane Hansen's message of "Wed, 20 Jul 2016 10:04:27 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122390 Archived-At: First, apologies for having left this alone this long. I meant to get to it earlier. Anyways, so the fix here is conceptually pretty simple: have a check in place to ensure (display-graphic-p) returns non-nil before doing any xwidgets stuff. Easy enough. What I want to solicit feedback on before I write a patch is this: who should be responsible for this check? Should the function provider (the xwidget C 'library') check for the proper support? Or should that be left to the user (the Lisp that calls the xwidget functions, in this case `xwidget-webkit-browse-url`)? Personal opinion is that xwidget should check: that way a Lisp caller can't forget to do so. But I'm largely unaware of the conventions on how to handle this, so I want to make sure I'm doing the correct thing before I make a style mistake. Thanks, -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871