unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#25399: [PATCH]
@ 2017-01-08 18:17 Oscar Najera
  2017-02-01  1:39 ` npostavs
  0 siblings, 1 reply; 3+ messages in thread
From: Oscar Najera @ 2017-01-08 18:17 UTC (permalink / raw)
  To: 25399, tzz

Hello,

I tried to use the auth-source-user-and-password function with the user
argument, but it always returns a list of nil. Looking at the code I see
that the argument is not used in the auth-source-search but that a fixed
string "yourusername" is used.

With this patch I obtain the correct behavior.

Thank you for your attention,
Best regards,
Oscar

---
 lisp/auth-source.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/auth-source.el b/lisp/auth-source.el
index c26935fcc9..7402ab21d7 100644
--- a/lisp/auth-source.el
+++ b/lisp/auth-source.el
@@ -2129,7 +2129,7 @@ MODE can be \"login\" or \"password\"."
                      (if user
                          (auth-source-search
                           :host host
-                          :user "yourusername"
+                          :user user
                           :max 1
                           :require '(:user :secret)
                           :create nil)





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#25399: [PATCH]
  2017-01-08 18:17 bug#25399: [PATCH] Oscar Najera
@ 2017-02-01  1:39 ` npostavs
  2017-02-01 15:27   ` Ted Zlatanov
  0 siblings, 1 reply; 3+ messages in thread
From: npostavs @ 2017-02-01  1:39 UTC (permalink / raw)
  To: Oscar Najera; +Cc: tzz, 25399

tags 25399 fixed
close 25399 26.1
quit

Oscar Najera <najera.oscar@gmail.com> writes:

> I tried to use the auth-source-user-and-password function with the user
> argument, but it always returns a list of nil. Looking at the code I see
> that the argument is not used in the auth-source-search but that a fixed
> string "yourusername" is used.

This was fixed in [1: 52515f1].

1: 2017-01-31 14:13:10 -0500 52515f1133f2b87c573524d83c86b08e70ce1c30
  auth-source-user-and-password: add forgotten user parameter





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#25399: [PATCH]
  2017-02-01  1:39 ` npostavs
@ 2017-02-01 15:27   ` Ted Zlatanov
  0 siblings, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2017-02-01 15:27 UTC (permalink / raw)
  To: npostavs; +Cc: Oscar Najera, 25399-done

On Tue, 31 Jan 2017 20:39:10 -0500 npostavs@users.sourceforge.net wrote: 

n> tags 25399 fixed
n> close 25399 26.1
n> quit

n> Oscar Najera <najera.oscar@gmail.com> writes:

>> I tried to use the auth-source-user-and-password function with the user
>> argument, but it always returns a list of nil. Looking at the code I see
>> that the argument is not used in the auth-source-search but that a fixed
>> string "yourusername" is used.

n> This was fixed in [1: 52515f1].

n> 1: 2017-01-31 14:13:10 -0500 52515f1133f2b87c573524d83c86b08e70ce1c30
n>   auth-source-user-and-password: add forgotten user parameter

Oh, thanks! I had missed this bug report because it had no subject line.

Ted





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-01 15:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-08 18:17 bug#25399: [PATCH] Oscar Najera
2017-02-01  1:39 ` npostavs
2017-02-01 15:27   ` Ted Zlatanov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).