From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27840: 26.0.50; vc-git-grep stopped working on git master Date: Sun, 30 Jul 2017 14:08:20 -0400 Message-ID: <8760e994rv.fsf@users.sourceforge.net> References: <87shhj3wtc.fsf@pokyo> <87inie93lp.fsf@users.sourceforge.net> <07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501438031 12509 195.159.176.226 (30 Jul 2017 18:07:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Jul 2017 18:07:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27840@debbugs.gnu.org, Tom Tromey To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 30 20:07:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbscK-0002qr-GE for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jul 2017 20:07:04 +0200 Original-Received: from localhost ([::1]:56093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbscP-0001j8-Uw for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jul 2017 14:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbscL-0001hn-7l for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 14:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbscI-0004ei-JX for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 14:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbscI-0004ec-EK for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbscI-0002tq-1P for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27840-submit@debbugs.gnu.org id=B27840.150143800911127 (code B ref 27840); Sun, 30 Jul 2017 18:07:01 +0000 Original-Received: (at 27840) by debbugs.gnu.org; 30 Jul 2017 18:06:49 +0000 Original-Received: from localhost ([127.0.0.1]:34507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbsc4-0002tP-Qw for submit@debbugs.gnu.org; Sun, 30 Jul 2017 14:06:49 -0400 Original-Received: from mail-io0-f195.google.com ([209.85.223.195]:36451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbsc2-0002tC-TC for 27840@debbugs.gnu.org; Sun, 30 Jul 2017 14:06:47 -0400 Original-Received: by mail-io0-f195.google.com with SMTP id j32so12166221iod.3 for <27840@debbugs.gnu.org>; Sun, 30 Jul 2017 11:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=VDYwBqHd8OGE8GMx0ZsfrEGVpv66JLcPcJEBBe0SLsM=; b=F5O4kbbBpNSLi+OpOYS8mR+ucMR7HDJdrzliZUbJPuVlA/oQkqBfTZGT+N0MC2wx8K Mx0reU/ZsIzwzFWxRqwdRA/3I/8EzsAtYFAtcYFxgq50XZcXMzoS/9BlGGsVu5Luv0UQ K5gBTlQxfcYPjaSbWM9/BoV8E5hxI4DPY1ZP83jzhdXVfaF4Zyt51EiXw5w7V6BlJZvb 9ey8JCe30RNwso4fThWFuXYcA1uN/ONInll9dEP6TEnk6Y9usYJtCItT3tnQGWpsPzgt LBQTZ/UTm9TeQCDbJGSUeTJALS6cLNojaidnVz/UWMIRJmkdTUhsPEjOxCKhsO6EHs3u 2kHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=VDYwBqHd8OGE8GMx0ZsfrEGVpv66JLcPcJEBBe0SLsM=; b=Zn8AKqdJVp/uRA5RHPvubc/VfSP4HHJuRdikRz8+RGuJR5pN/5sYU5W5k/1LVzzd8r RI3615HDDf4541UO7YQRq7lwgNlBGQS8t4qx0M1pnCHUm1IrPwe7xNDqAlTToPVJ72bI jA87rTLUYZ2osAuMeyetfF+Xe1ZBjW/pc4mk8kneGOfiUYnPOARTe8ydbZfp+MKtp15o EbSb4KxXxZBCzr2biAvc4J9L3jymPtmuS18NcYY7kY3kwb+tGtWuvYkg1Xya/tpBhpcN lFgal2QLBGIHdEw2GuQdbsUXV4gakkP9rr+3pYSsDdNV/X0TfukVEoXi6SoWfCHtPAdX XyeA== X-Gm-Message-State: AIVw113nNeK7UZYFkEvszwvFIlO4uh5pPEo9TqH0XlD+bEG9gGyBhzJR sFPUwOgIp83Cqr81 X-Received: by 10.107.166.203 with SMTP id p194mr1905220ioe.48.1501438001267; Sun, 30 Jul 2017 11:06:41 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 63sm512530ith.4.2017.07.30.11.06.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Jul 2017 11:06:40 -0700 (PDT) In-Reply-To: <07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru> (Dmitry Gutov's message of "Thu, 27 Jul 2017 16:23:06 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135165 Archived-At: Dmitry Gutov writes: > On 7/27/17 2:32 AM, npostavs@users.sourceforge.net wrote: > >> Perhaps we should >> instead disable this option by default; when I introduced it, I didn't >> think about the fact that grep.el is used for not-quite-grep programs as >> well. > > Or we can try to think of them as separate. I.e., the patch below also > works. Right, but the question is: are there n+1 other places where we will need to do this? > And if we want to use the --null option for vc-git-grep, we can > construct a derivative alist in vc-git.el. > > Up to you, of course. > > (let ((default-directory dir) > - (compilation-environment (cons "PAGER=" compilation-environment))) > + (compilation-environment (cons "PAGER=" compilation-environment)) > + grep-use-null-filename-separator)