From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#28003: 26.0.50; Auto fill broken in Message mode Date: Wed, 09 Aug 2017 06:37:42 -0600 Message-ID: <8760dwx6g9.fsf@pokyo> References: <87shh3cft1.fsf@rosalinde> <87valxxglm.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502282359 7841 195.159.176.226 (9 Aug 2017 12:39:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 Aug 2017 12:39:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Katsumi Yamaoka , Tom Tromey , 28003@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 09 14:39:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfQGT-0001ac-Vw for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Aug 2017 14:39:10 +0200 Original-Received: from localhost ([::1]:47339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfQGa-0000oR-BB for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Aug 2017 08:39:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfQGQ-0000o8-Fq for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 08:39:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfQGM-0001lL-Gk for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 08:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfQGM-0001l4-6L for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 08:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dfQGL-0007eo-RT for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2017 08:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Aug 2017 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28003 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28003-submit@debbugs.gnu.org id=B28003.150228228829373 (code B ref 28003); Wed, 09 Aug 2017 12:39:01 +0000 Original-Received: (at 28003) by debbugs.gnu.org; 9 Aug 2017 12:38:08 +0000 Original-Received: from localhost ([127.0.0.1]:52767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfQFT-0007dg-Tj for submit@debbugs.gnu.org; Wed, 09 Aug 2017 08:38:08 -0400 Original-Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:43889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfQFR-0007dC-GM for 28003@debbugs.gnu.org; Wed, 09 Aug 2017 08:38:06 -0400 Original-Received: from cmgw4 (unknown [10.0.90.85]) by gproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id E4B824009E for <28003@debbugs.gnu.org>; Wed, 9 Aug 2017 06:37:55 -0600 (MDT) Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id v0do1v0012f2jeq010drMw; Wed, 09 Aug 2017 06:37:55 -0600 X-Authority-Analysis: v=2.2 cv=ELV26xRC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=KeKAF7QvOSUA:10 a=VVlED5B4AAAA:8 a=5MCkQwerAAAA:8 a=0uDOl1xouTGrhtdPeOEA:9 a=gxddS5h7sIkLbkylXVf9:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VQHjmVp2Hhy153EG0ZfFRdxifPujAIA4XRsFQhBj3p8=; b=uVVkseJ6lWBeei+EPIzv1zodIS pAqC8VRyd7KKm2/Qqy27SKKdbHhd+3jdpn3ptFonDRoiEXBmXI8UP3qPCJ+XD2RYJJFF1dNhWK5JL Fny7+wpWZpuV+eKkNfC/3HM68; Original-Received: from 75-166-24-97.hlrn.qwest.net ([75.166.24.97]:45998 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dfQF9-004FcP-PN; Wed, 09 Aug 2017 06:37:47 -0600 X-Attribution: Tom In-Reply-To: <87valxxglm.fsf@rosalinde> (Stephen Berman's message of "Wed, 09 Aug 2017 10:58:29 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.24.97 X-Exim-ID: 1dfQF9-004FcP-PN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-24-97.hlrn.qwest.net (pokyo) [75.166.24.97]:45998 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135598 Archived-At: >>>>> "Stephen" == Stephen Berman writes: Stephen> On Wed, 09 Aug 2017 12:33:01 +0900 Katsumi Yamaoka wrote: >> On Mon, 07 Aug 2017 21:56:42 +0200, Stephen Berman wrote: >>> This change: >> [...] >>> broke auto filling in Message mode; the breakage is due specifically to >>> this change in comment-indent-new-line: >> >> This will probably be no more than a workaround, though. >> >> --- message.el~ 2017-08-08 22:08:28.694840400 +0000 >> +++ message.el 2017-08-09 03:30:33.407170200 +0000 >> @@ -3451,7 +3451,7 @@ >> (defun message-do-auto-fill () >> "Like `do-auto-fill', but don't fill in message header." >> (unless (message-point-in-header-p) >> - (do-auto-fill))) >> + (let ((comment-start nil)) (do-auto-fill)))) >> >> (defun message-insert-signature (&optional force) >> "Insert a signature. See documentation for variable `message-signature'." Stephen> This change doesn't fix the problem. I don't know what the motivation Stephen> for the change that caused this problem was, so I don't know how to fix Stephen> it; cc'ing Tom Tromey, who made the change. I've been discussing this off-list with another person who ran into this problem, but I haven't managed to reproduce it myself. I suspect the newcomment.el change is incorrect and should be reverted. Could you try that? The other changes should, I think, remain in place though. The basic idea of my patch is to make comment-auto-fill-only-comments work properly. Without it, setting comment-auto-fill-only-comments and enabling auto-fill in js-mode will cause auto-filling even when typing a long line of code, which is clearly incorrect. thanks, Tom