From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#28008: 25.2; Resume kmacro definition errors C-u C-u Date: Sat, 12 Aug 2017 12:03:45 +0900 Message-ID: <8760dt32su.fsf@calancha-pc> References: <87d1867hpd.fsf@calancha-pc> <87d182p97t.fsf@calancha-pc> <83shgyqmwn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502507118 21655 195.159.176.226 (12 Aug 2017 03:05:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2017 03:05:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: vianchielfaura@gmail.com, 28008@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 12 05:05:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgMjh-000561-5n for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Aug 2017 05:05:13 +0200 Original-Received: from localhost ([::1]:46640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgMji-0006ir-Tp for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 23:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgMjb-0006gX-M9 for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 23:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgMjX-00020V-LY for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 23:05:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgMjX-00020M-Hw for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 23:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgMjX-0005Ip-3Y for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 23:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2017 03:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28008 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28008-submit@debbugs.gnu.org id=B28008.150250704320316 (code B ref 28008); Sat, 12 Aug 2017 03:05:03 +0000 Original-Received: (at 28008) by debbugs.gnu.org; 12 Aug 2017 03:04:03 +0000 Original-Received: from localhost ([127.0.0.1]:56187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgMiW-0005HJ-Hh for submit@debbugs.gnu.org; Fri, 11 Aug 2017 23:04:00 -0400 Original-Received: from mail-pf0-f177.google.com ([209.85.192.177]:35491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgMiU-0005H5-WA for 28008@debbugs.gnu.org; Fri, 11 Aug 2017 23:03:59 -0400 Original-Received: by mail-pf0-f177.google.com with SMTP id t86so22378160pfe.2 for <28008@debbugs.gnu.org>; Fri, 11 Aug 2017 20:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eXVbFh3SYzvfCrvY/e7EIdTCHcozQvF4+ImxdgobwbY=; b=O6QXm6Vyp0lkwSLGfvNsEl98jhO48+e7pUh4UH1Bumchm4V8knC2cIWDnwqqd6i7CC RsvNAPqwcM3o1LIbrNyoh4HRDKpIGvU78Mr6HRNwGHGP5qLqouN2dYXo4HSwi4Tj2i/Q wbwdqMXB1LEHHCouc8OjKUHxNhuDY2eNJO9rX5S+rIODtslDMvKnHhOb5DsfO1lYlZcS FJgBxPQoeNjGUMEgteLoGmyh4eMId770zawvrBIil34x7JFR/bltXS6ntzxaO+Rh1LON nsj6x4KRQEMx3/oDx4XmwqPLy0+IRe+NcpSql8fSlVR6TV8LPVwgnbNVKXjFZF3V7VO+ 7Sqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eXVbFh3SYzvfCrvY/e7EIdTCHcozQvF4+ImxdgobwbY=; b=cltfoX8fRiz3BCZ+0qyyvfRssy70Td0vzyrSJXYBCV0lxzPdp9wE3HdG0F2WyLZwVX uIasOS2Oi6Z30/V/pxRxhKDy1D8xyT2i3NQdeSaTbQ+9YyGCLs5WYFB/zig+buc8MjeS YtVmYaQ/072nTC26L3MlSkTkd9vjdG3twm7I5diIxTyxTdwcXHKUxDwHgRXLKEaYzK2S XZ81s0rDX+hUuRAClLpJA7Vn/fbClRWaRMdC+NmtZ2/1t7T9gH2DdBl/DidJHv6Zqcf0 6QKeyVIoDwJ/mQqcmRjHBRquZUcu5wLpWd2Zu2FWPzY8D5WsXMLcC4GJinIKdGkRwd5d zeTw== X-Gm-Message-State: AHYfb5j0BMAJU3NQmTtxstOgeJ1W4BBX9P1PCHe0Dnn1XqgkkI+2ve6w lvY4Gf9yeiTNd9rC X-Received: by 10.84.241.197 with SMTP id t5mr20539957plm.473.1502507033082; Fri, 11 Aug 2017 20:03:53 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id 69sm4471076pfh.186.2017.08.11.20.03.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Aug 2017 20:03:52 -0700 (PDT) In-Reply-To: (Tino Calancha's message of "Fri, 11 Aug 2017 22:17:57 +0900 (JST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135669 Archived-At: Tino Calancha writes: > On Fri, 11 Aug 2017, Eli Zaretskii wrote: > >>> ** Patch 1 always save the macro in `last-kbd-macro' after an error or 'C-g'. >>> Then, A. B. and D.2 behaves similarly. > Actually, the patch#1 is quite short: i included a docstring fix from > the patch#2 by mistake. The commit message of patch#1 got too verbose. It shouldn't mention about 'last-aborted-kbd-macro' (that variable belongs to patch#2): Following is a revisede commit message for patch#1: --8<-----------------------------cut here---------------start------------->8--- Save aborted kbd macro definitions While a defining a kbd macro, if we get an error or if the user inputs C-g, then save the aborted kbd macro record (Bug#28008). * lisp/kmacro.el (kmacro-start-macro): Signal an error if APPEND is non-nil and last-kbd-macro is nil. * src/keyboard.c (cmd_error): Increase buffer size for macroerror to accommodate new error message. If we are defining a kbd macro and we got an error, then save the current progress in last-kbd-macro. * src/macros.c (save_aborted_kbd_macro): New function. (store_kbd_macro_char): Call save_aborted_kbd_macro when user inputs C-g. --8<-----------------------------cut here---------------end--------------->8---