From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#28033: [PATCH] Add new face 'header-line-highlight' Date: Sat, 12 Aug 2017 21:05:42 -0600 Message-ID: <8760dsmak9.fsf@lylat> References: <87bmno7228.fsf@lylat> <83k22crrfg.fsf@gnu.org> <874ltg6l2k.fsf@lylat> <83k22aqdwd.fsf@gnu.org> <87mv75iwn9.fsf@lylat> <83a835qml8.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1502593640 29841 195.159.176.226 (13 Aug 2017 03:07:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Aug 2017 03:07:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28033-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 13 05:07:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgjF5-0006tE-MI for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 05:07:07 +0200 Original-Received: from localhost ([::1]:49395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgjFA-0005p6-0q for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Aug 2017 23:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgjF3-0005oQ-Tp for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 23:07:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgjF0-00060j-Nm for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 23:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgjF0-00060S-IF for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 23:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgjF0-0003EE-8T for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 23:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2017 03:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28033-done@debbugs.gnu.org id=D28033.150259357912403 (code D ref 28033); Sun, 13 Aug 2017 03:07:02 +0000 Original-Received: (at 28033-done) by debbugs.gnu.org; 13 Aug 2017 03:06:19 +0000 Original-Received: from localhost ([127.0.0.1]:59072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgjEI-0003Dz-Uu for submit@debbugs.gnu.org; Sat, 12 Aug 2017 23:06:19 -0400 Original-Received: from mail-io0-f196.google.com ([209.85.223.196]:34483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgjEH-0003Dt-F3 for 28033-done@debbugs.gnu.org; Sat, 12 Aug 2017 23:06:17 -0400 Original-Received: by mail-io0-f196.google.com with SMTP id m88so5757412iod.1 for <28033-done@debbugs.gnu.org>; Sat, 12 Aug 2017 20:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OtK+8l5Kk8KOKMgBEbKUQLG3zyjWAIm15Kx7QDmZGgU=; b=rty6dc3Aa0VTWqyEPDlggBr2PBixhwLYjjGEArfCWJ/C+SbjZzaND/q6hvHUYU7dHd zO61WJHvKw9pYGmFnpbGSRKAMzna1eekAdYp8PxErjUttxjakKhX2Se8BXs7/SS4obxl u7cYIJ5wxZO5FrvVX/ndt8/d5Kj6AvwVvypdoUqLtfOFcTTsAFBXnmKFk42EiWqIgpmi MSBL0O/ijYEKKx1D6HmdnjXjnrQYXoaUup1a2Byr63os3ybMMN6Z8yprTPN3f48Ig8TB woffrcgXWGEd7iHJapFi3Niz6Pt0AqppK1ygTfwUwRgZCjkrG+fQ392rslawTRGBEFWI mHlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OtK+8l5Kk8KOKMgBEbKUQLG3zyjWAIm15Kx7QDmZGgU=; b=hbOlsyDb1LDkCNfooHuDgn0f6UAdNXIOLeg8DjiwAhgk9MbR2qvclW3S+H78tTnWeE aYxXPvQeDRH3ljTJtXIg8BPSzr89/hIbNuslBXyptot6A7vy6P5nCvajZF1sDQxhAfxs 3jm53irP9gkGIwJWzj/AbGGbeeANMpjZ83mPk0hk2TmT34QHcxC9UXLKGgXLXp78bs/C zx3C1tA+OGTJJwOkRLmegMXiGyP6ZwSMlwmIOL9x7NY+2wqVH7tR4WfJ4fl0KJz584FD +yRtgRphWkUImAJgqecKAt4bP6Ro7snoIJ2eFZBiIpAb1gM3jm1SGAweq7uqZHCCnjIe JIRQ== X-Gm-Message-State: AHYfb5iU88Yfykv2wuOWG0ZRZ/rVZoGmslL6az1eXV5x1y27lKbi7Z6e GGCjGi+9hcxzZGFy X-Received: by 10.107.161.68 with SMTP id k65mr18157450ioe.334.1502593571645; Sat, 12 Aug 2017 20:06:11 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id h187sm1355199ita.1.2017.08.12.20.06.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Aug 2017 20:06:10 -0700 (PDT) In-Reply-To: <83a835qml8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Aug 2017 10:20:03 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135711 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > . The order of the references to various parts of the changes in the > log message should assume the reading order of top to bottom, so > the log message might need some minor reordering. In this case, > your original order: I was going for a mostly alphabetical ordering. I take it that doesn't matter? >> * doc/emacs/display.texi (Standard Faces): >> * etc/NEWS: Document the face. >> * lisp/emacs-lisp/tabulated-list.el (tabulated-list-init-header): >> * lisp/info.el (Info-fontify-node): Use the face. >> * lisp/faces.el: Define the face. > > refers to "the face" before it was defined. I've reordered it to > put the reference to the lisp/faces.el change before all the rest. I don't really understand this part (though I don't mind following it). Only the commit summary line references the face by name, and the summary is already at the top. Why does it matter that, in the actual program execution, the face has to be defined first? P.S. I happened upon two more places to add this face to. Would you please push this as well? Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-header-line-highlight-in-proced-and-erc.patch >From 4aaff22bf46ad72922cd72a01eb841b60fb2eace Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sat, 12 Aug 2017 20:45:33 -0600 Subject: [PATCH] Use 'header-line-highlight' in proced and erc * lisp/erc/erc-list.el (erc-list-button): * lisp/proced.el (proced-format): Use the face. --- lisp/erc/erc-list.el | 2 +- lisp/proced.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/erc/erc-list.el b/lisp/erc/erc-list.el index 5110239f61..7d6413ee7f 100644 --- a/lisp/erc/erc-list.el +++ b/lisp/erc/erc-list.el @@ -145,7 +145,7 @@ erc-list-button (erc-propertize title 'column-number column 'help-echo "mouse-1: sort by column" - 'mouse-face 'highlight + 'mouse-face 'header-line-highlight 'keymap erc-list-menu-sort-button-map)) (define-derived-mode erc-list-menu-mode special-mode "ERC-List" diff --git a/lisp/proced.el b/lisp/proced.el index be3b7c41a6..18693f4556 100644 --- a/lisp/proced.el +++ b/lisp/proced.el @@ -1438,7 +1438,7 @@ proced-format (hprops (if (nth 4 grammar) (let ((descend (if (eq key sort-key) proced-descend (nth 5 grammar)))) - `(proced-key ,key mouse-face highlight + `(proced-key ,key mouse-face header-line-highlight help-echo ,(format proced-header-help-echo (if descend "-" "+") (nth 1 grammar) -- 2.13.2 --=-=-=--