From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27974: Acknowledgement (25.2; string-rectangle on-the-fly preview bad) Date: Sun, 15 Oct 2017 22:05:02 -0400 Message-ID: <8760bfj19t.fsf@users.sourceforge.net> References: <87wp6hyeje.fsf@hysteria.proulx.com> <20170805150035534719984@bob.proulx.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1508119589 27919 195.159.176.226 (16 Oct 2017 02:06:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 02:06:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 27974@debbugs.gnu.org To: Bob Proulx Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 04:06:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3un7-0004Kt-7T for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 04:06:05 +0200 Original-Received: from localhost ([::1]:58975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3unE-0000Ii-Jp for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 22:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3un8-0000Ia-GW for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 22:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3un4-0002Mq-GZ for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 22:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3un4-0002Mf-Ao for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 22:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3un3-00049y-Ml for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 22:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27974 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27974-submit@debbugs.gnu.org id=B27974.150811951815935 (code B ref 27974); Mon, 16 Oct 2017 02:06:01 +0000 Original-Received: (at 27974) by debbugs.gnu.org; 16 Oct 2017 02:05:18 +0000 Original-Received: from localhost ([127.0.0.1]:42181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3umM-00048w-Ap for submit@debbugs.gnu.org; Sun, 15 Oct 2017 22:05:18 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:47165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3umJ-00048j-VZ for 27974@debbugs.gnu.org; Sun, 15 Oct 2017 22:05:16 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id h70so14441434ioi.4 for <27974@debbugs.gnu.org>; Sun, 15 Oct 2017 19:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+NHEi6mcCHUL0aM7M554sk7rNcCrxmVHiqTjiSzZ/6c=; b=mnqH2yifvFqp7CsKcv8Inq17sx5Wj1/h67EsCC5gUaMRes5J4gPxh2RijT2v+GFw/M 7fE5Z/pIN+S0P+KBPcQAx9xyJ3V6bR+zyGUi97D3lGIl80qSIT+MfjKIsyjlQbJvzFau 7URHVUtr2Pn5MTR280sdnobWNOGkujNkmPt1vu7nuEZEWYmgLz27B1j7em8xNnVrcjOM aTCgGY0c6rE5BQxTOqjjUS9PS+bxeYU/bQl05O8GZv/mCSywIsulPbMXrkMH/PVFVF4w 6VsrdEauX35dS02/QTRRO7Bmc/79DjueHtc+OHobN/XqYqpxWzDEX62P7s4QJDwwk8iO UfSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+NHEi6mcCHUL0aM7M554sk7rNcCrxmVHiqTjiSzZ/6c=; b=iPLE6M8cIez5/USXmsvPKUgQeHzMdQ6RRIVTufH91fyxaugJr/38vCuGAHbACCbB+g zcGWyiwjOfW4dR8anJ02FaPsz9D6XyVy25RfMy/etGQJPWjdn4nhvOM5mb+43BsvQC7m wbmWm3xe+6O2jgd6bihd7Ve7PrUfZiGDn51HiThorGJLbGODCZpBjgNtO/c6vPVs3OFI vYycU5tHOGMC3BjnpH4Denary5wC+uNwbVoKpknh+ctM6+zNHN6tlYS6lzSGe6PKRajn Tp67ycl/rjD9NZFzMywR3c3q3qWaQgzjH1NMrpVTuDXARmDtXySsAvMVKwjoMmpoHU40 h6mw== X-Gm-Message-State: AMCzsaUCtGkA6YtbHrxwbsI8/iRzFkb4uHgXhsme4Gtgj/xcEkM8wwQT cfuCWSImX+a6M9K1tUvSLTFTyw== X-Google-Smtp-Source: ABhQp+Tc42Y7nAGpEajdJCaInFDdnqg80aTRy+Dv5BfwcNky+nrfT0PgYsUMQg+rstE8Buu8EaTiSA== X-Received: by 10.107.11.73 with SMTP id v70mr11273418ioi.260.1508119510080; Sun, 15 Oct 2017 19:05:10 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g195sm3455120itc.14.2017.10.15.19.05.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Oct 2017 19:05:08 -0700 (PDT) In-Reply-To: <20170805150035534719984@bob.proulx.com> (Bob Proulx's message of "Sat, 5 Aug 2017 15:11:03 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138487 Archived-At: --=-=-= Content-Type: text/plain Bob Proulx writes: > Let me suggest the following addition to the NEWS file. > > *** 'string-rectangle' provides on-the-fly preview of the result. > +This is controlled by the rectangle-preview variable. Defaults to t. > +Set (setq rectangle-preview nil) if you want the previous behavior. I think it should also be documented in the docstring of string-rectangle: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Document-rectangle-preview-option-more-Bug-27974.patch Content-Description: patch >From 4fd248152d15218e3f9f1d3747cebdad87062513 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 15 Oct 2017 17:09:09 -0400 Subject: [PATCH v2] Document rectangle-preview option more (Bug#27974) * lisp/rect.el (string-rectangle): * etc/NEWS.25: Mention `rectangle-preview'. --- etc/NEWS.25 | 2 ++ lisp/rect.el | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/etc/NEWS.25 b/etc/NEWS.25 index 5201a300e0..aac60c4688 100644 --- a/etc/NEWS.25 +++ b/etc/NEWS.25 @@ -712,7 +712,9 @@ CLOS class and slot documentation. *** Rectangle Mark mode can have corners past EOL or in the middle of a TAB. *** 'C-x C-x' in 'rectangle-mark-mode' now cycles through the four corners. + *** 'string-rectangle' provides on-the-fly preview of the result. +Customize 'rectangle-preview' to nil for the old behavior. ** New font-lock functions 'font-lock-ensure' and 'font-lock-flush'. These should be used in preference to 'font-lock-fontify-buffer' when diff --git a/lisp/rect.el b/lisp/rect.el index 12e62b6a99..4ad7a98dda 100644 --- a/lisp/rect.el +++ b/lisp/rect.el @@ -450,6 +450,10 @@ string-rectangle "Replace rectangle contents with STRING on each line. The length of STRING need not be the same as the rectangle width. +When called interactively and option `rectangle-preview' is +non-nil, the result is previewed as the string is entered in the +minibuffer. + Called from a program, takes three args; START, END and STRING." (interactive (progn -- 2.11.0 --=-=-=--