unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30560@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#30560: Better format for view-lossage
Date: Fri, 23 Feb 2018 11:09:52 +0100	[thread overview]
Message-ID: <87606of24v.fsf@gmail.com> (raw)
In-Reply-To: <837er45gz2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Feb 2018 08:59:29 +0200")

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Juri Linkov <juri@linkov.net>
>> Date: Thu, 22 Feb 2018 23:59:42 +0200
>> 
>> > This patch is for master:
>> 
>> Pushed to master and closed.
>
> Thanks, but please in the future leave more than just 2 days for
> people to comment on the patches you propose.
>
> IMO, this change needs to be mentioned in NEWS.

Might I suggest the following as well? Does this need mentioning in
the info docs?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Describe-view-lossage-changes-in-its-docstring.patch --]
[-- Type: text/x-diff, Size: 1845 bytes --]

From 45c4f1a42e1e47f79055545a3fcf5a7d117e1caf Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Fri, 23 Feb 2018 11:01:23 +0100
Subject: [PATCH] Describe `view-lossage' changes in its docstring

* lisp/help.el (view-lossage): Mention that this now uses the same
format as `edit-last-kbd-macro'.
---
 etc/NEWS     | 11 ++++++-----
 lisp/help.el |  3 ++-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index dacaf023bb..3fa2670d60 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -167,11 +167,12 @@ directories in the destination.
 
 ** Help
 
-*** 'C-h l' (view-lossage) now displays last keystrokes and commands
-in the same format as the edit buffer of edit-last-kbd-macro.
-This makes possible to copy the lines from the buffer generated
-by 'view-lossage', yank them to the buffer "*Edit Macro*" created by
-'edit-last-kbd-macro', and save the macro by 'C-c C-c'.
+*** 'C-h l' (view-lossage) buffer format has changed.
+For convenience the lossage buffer now displays the last keystrokes
+and commands in the same format as the edit buffer of
+'edit-last-kbd-macro'.  This makes it possible to copy the lines from
+the buffer generated by 'view-lossage' to the "*Edit Macro*" buffer
+created by 'edit-last-kbd-macro', and save the macro by 'C-c C-c'.
 
 ** Ibuffer
 
diff --git a/lisp/help.el b/lisp/help.el
index 9575f5b090..917c25e427 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -454,7 +454,8 @@ view-external-packages
   (info "(efaq)Packages that do not come with Emacs"))
 
 (defun view-lossage ()
-  "Display last few input keystrokes and the commands run.
+  "Display last few input keystrokes and the commands run.  For
+convenience this uses the same format as `edit-last-kbd-macro'.
 
 To record all your input, use `open-dribble-file'."
   (interactive)
-- 
2.16.1.72.g5be1f00a9


  reply	other threads:[~2018-02-23 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 21:17 bug#30560: Better format for view-lossage Juri Linkov
2018-02-22 21:59 ` Juri Linkov
2018-02-23  6:59   ` Eli Zaretskii
2018-02-23 10:09     ` Robert Pluim [this message]
2018-02-23 10:20       ` martin rudalics
2018-02-23 11:08         ` Robert Pluim
2018-02-24 11:17           ` Eli Zaretskii
2018-02-23 13:55       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87606of24v.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=30560@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).