From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pierre =?UTF-8?Q?T=C3=A9choueyres?= Newsgroups: gmane.emacs.bugs Subject: bug#30673: [PATCH] Allow `browse-url-emacs' to fetch url in same window. Date: Fri, 02 Mar 2018 01:14:03 +0100 Message-ID: <87606fe3lg.fsf@killashandra.ballybran.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1519949591 7268 195.159.176.226 (2 Mar 2018 00:13:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Mar 2018 00:13:11 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 26.0.91 To: 30673@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 02 01:13:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erYJu-0001B4-3Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Mar 2018 01:13:06 +0100 Original-Received: from localhost ([::1]:59845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erYLu-0006iw-So for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Mar 2018 19:15:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erYLo-0006ip-Jr for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:15:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erYLn-00008h-HJ for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:15:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erYLn-00007G-7O for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1erYLm-0005iL-Ux for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pierre =?UTF-8?Q?T=C3=A9choueyres?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Mar 2018 00:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.151994965721892 (code B ref -1); Fri, 02 Mar 2018 00:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Mar 2018 00:14:17 +0000 Original-Received: from localhost ([127.0.0.1]:39871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erYL3-0005h2-6p for submit@debbugs.gnu.org; Thu, 01 Mar 2018 19:14:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erYL1-0005gm-1U for submit@debbugs.gnu.org; Thu, 01 Mar 2018 19:14:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erYKu-0007jk-RB for submit@debbugs.gnu.org; Thu, 01 Mar 2018 19:14:09 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:38903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erYKu-0007jT-MQ for submit@debbugs.gnu.org; Thu, 01 Mar 2018 19:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erYKt-0006cH-IV for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:14:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erYKs-0007hQ-JC for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:14:07 -0500 Original-Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:53480) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erYKs-0007gE-CO for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 19:14:06 -0500 Original-Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e35:2e14:eab0:b51f:3dc7:7e03:942]) by smtp4-g21.free.fr (Postfix) with ESMTPS id 14EA619F522 for ; Fri, 2 Mar 2018 01:14:03 +0100 (CET) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143811 Archived-At: --=-=-= Content-Type: text/plain Here is a patch to allow browse-url-emacs to be invoked in a way to reuse the current window. Could it be included into master branch ? I guess it's too late for emacs-26. Thanks --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Allow-browse-url-emacs-to-fetch-url-in-same-window.patch Content-Description: browse-url-emacs >From 8bd95d79c32b29bd11202ced04fd811d4a8f6119 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= Date: Thu, 1 Mar 2018 22:22:05 +0100 Subject: [PATCH] Allow `browse-url-emacs' to fetch url in same window. * lisp/net/browse-url.el (browse-url-emacs): add same-window argument. --- lisp/net/browse-url.el | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el index 98b0acfc0c..a8055d1dc9 100644 --- a/lisp/net/browse-url.el +++ b/lisp/net/browse-url.el @@ -1243,18 +1243,14 @@ browse-url-epiphany-sentinel (defvar url-handler-regexp) ;;;###autoload -(defun browse-url-emacs (url &optional _new-window) +(defun browse-url-emacs (url &optional same-window) "Ask Emacs to load URL into a buffer and show it in another window." (interactive (browse-url-interactive-arg "URL: ")) (require 'url-handlers) (let ((file-name-handler-alist (cons (cons url-handler-regexp 'url-file-handler) file-name-handler-alist))) - ;; Ignore `new-window': with all other browsers the URL is always shown - ;; in another window than the current Emacs one since it's shown in - ;; another application's window. - ;; (if new-window (find-file-other-window url) (find-file url)) - (find-file-other-window url))) + (if same-window (find-file url) (find-file-other-window url)))) ;;;###autoload (defun browse-url-gnome-moz (url &optional new-window) -- 2.14.3 --=-=-=--