From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Sat, 17 Mar 2018 10:54:46 -0400 Message-ID: <87605uvjk9.fsf@gmail.com> References: <87vaiprmg5.fsf@gmail.com> <878taqvk3r.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521298390 7828 195.159.176.226 (17 Mar 2018 14:53:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Mar 2018 14:53:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Eric Skoglund , Pierre Neidhardt To: 29156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 17 15:53:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exDCj-0001wQ-3G for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 15:53:05 +0100 Original-Received: from localhost ([::1]:33960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exDEl-0006oS-Tb for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 10:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exDEf-0006oI-3z for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exDEc-0003Xk-31 for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58901) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exDEb-0003XP-Ug for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1exDEb-0000T3-KQ for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Mar 2018 14:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.15212984961782 (code B ref 29156); Sat, 17 Mar 2018 14:55:01 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 17 Mar 2018 14:54:56 +0000 Original-Received: from localhost ([127.0.0.1]:38565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exDEW-0000Sg-5a for submit@debbugs.gnu.org; Sat, 17 Mar 2018 10:54:56 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:52624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exDET-0000SS-NX for 29156@debbugs.gnu.org; Sat, 17 Mar 2018 10:54:54 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id k135-v6so5392430ite.2 for <29156@debbugs.gnu.org>; Sat, 17 Mar 2018 07:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6FE2UZ9h1TaN8cUWVo/XQZpDrZlm85Tb7hP7oLvxPtA=; b=Z0O1UgZ2hAjPclhu8IrWoLXIMw4vGTWHjMoXk5LtNPiWsTRN9Chn96yXNO1Fo/o1St sNLTbBJolShrdGhjIkXzWBMlUDR8uYsFbkrm7wJMePQAY8rxuYv5uguX2IoaXq0Ao/9g KoTYbQho0fp/KLzW14Rcq/0vU11nf7KXsyNZVUdQzzF6JZ6nwXxL82KG6/9fJanF9MMQ LmkRVAXcRQjUzPboQOGt6HzWB5DDop/lQY6zcJFx3EPue1ZamjbRwoaAO6erI4eDJJrc QjDzzxW/x93w9ykcNienSEwMQ+G07mFWyeii2DOH56NrwABWoo5xrRf7/ZJtIuplJPmN Tnuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6FE2UZ9h1TaN8cUWVo/XQZpDrZlm85Tb7hP7oLvxPtA=; b=UTddMkaZDp7UC0/bI+fp2SlSxhmimmaXf40vNgD5PV9Z4hXcWroM/rA1OBdCEw4AKD 3PHSsg6LXAq8G1iKJFSCRVUwHNsIAwsV3y05J27zZz6G9Njv3mCkCyukJ7m0fW/jIxKb rDUDqCh5Dikr18rDGeiNFlwoKmTUV2gsys0GlN8Ezmy6yk8ja14GDjwg2aKVnGuz6fC5 hEZFHx7SvPmw4T/uHFW9hM122HJewlFiKmABWuyVAah1StT9C/MmuO+n6PE7ILlMZT4L 9hT6VFIM9ynUZwd0If5eMCBUrQqlb69zU+yT5ybQHVOaswYtb87Ia9brUMqvEHLmodTj /b4g== X-Gm-Message-State: AElRT7FrXs6Q6JNrKGwi5ZzBYbIjo20BnKdHjNsRxaCP8wLJTG4pxYqf 8LPWrXL4I3KHz9zcOSf6Nwg= X-Google-Smtp-Source: AG47ELts/0P+nl25tPCtGLaLPTb0Hkl1npiaON/wutqmv6DrvqcZ0WXXgRtN24qoixIw0i9ZF536hw== X-Received: by 2002:a24:6794:: with SMTP id u142-v6mr6041122itc.19.1521298488007; Sat, 17 Mar 2018 07:54:48 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w132sm5907178itf.6.2018.03.17.07.54.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 07:54:47 -0700 (PDT) In-Reply-To: <878taqvk3r.fsf@gmail.com> (Noam Postavsky's message of "Sat, 17 Mar 2018 10:43:04 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144366 Archived-At: > From: Eric Skoglund >> More importantly, could you explain a bit how your change works/why it's >> correct? > > I'm guessing you mean in the commit message and not here in the bug > report right? Either, both :) (If you send a new patch with the explanation in the commit message, it's automatically in the bug report as well anyway) >> Not sure [about] this `make-symbol' call, should it rather be >> `intern'? (Maybe we should update signal-process take a string as >> well a symbol.) > > Saw that Eli also agreed, for future reference when do we want to use > `make-symbol` vs `intern`? Usually, `make-symbol' is only for macros, where you want a symbol that is not `eq' to any other. Sometimes it's handy for making a unique object at run-time. In this case, since we only care about the symbol name, it doesn't really matter, it's just a bit surprising to see it because it's usually a mistake in a non-macro context.