bug#13955: Subject: 24.3; (thing-at-point 'list) fails

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Andreas Röhler]

("asdf")

Cursor at char "f" of "asdf"

M-: (thing-at-point 'list) RET

returns "f" while it should give the whole list ("asdf")

Thanks all!

Andreas

In GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 2.24.14)
  of 2013-03-05
Windowing system distributor `The X.Org Foundation', version 11.0.11302000
System Description:	openSUSE 12.3 Beta 1 (i586)

Configured using:
  `configure 'CFLAGS=-g -O2 -fno-optimize-sibling-calls''

Important settings:
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LANG: de_DE.utf8
   value of $XMODIFIERS: @im=local
   locale-coding-system: utf-8-unix
   default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
( " a s d f " ) <left> <left> <left> <left> <left>
<right> <right> M-: ( t h i n g - a t - p o i n t SPC
' l i s t ) <return> M-x r e p o r t - e m a c s -
b u <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
#("f" 0 1 (fontified t face font-lock-string-face))

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils thingatpt time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Andreas Röhler]

[-- Attachment #1: Type: text/plain, Size: 15 bytes --]

patch attached

[-- Attachment #2: list-at-point.patch --]
[-- Type: text/x-patch, Size: 1088 bytes --]

commit d9584f48eaae3b0827501de93058cb8cf584b9fb
Author: Andreas Roehler <andreas.roehler@online.de>
Date:   Thu Mar 14 16:23:55 2013 +0100

    Fixes bug#13955
    
    Subject: 24.3; (thing-at-point 'list) fails
    
    TINYCHANGE

diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 9526cb7..29ea1a2 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -209,11 +209,15 @@ The bounds of THING are determined by `bounds-of-thing-at-point'."
   "Return the bounds of the list at point.
 \[Internal function used by `bounds-of-thing-at-point'.]"
   (save-excursion
-    (let ((opoint (point))
-	  (beg (condition-case nil
-		   (progn (up-list -1)
-			  (point))
-		 (error nil))))
+    (let* ((opoint (point))
+           (pps (syntax-ppss))
+           (beg (progn
+                  (and (nth 8 pps)
+                       (goto-char (nth 8 pps)))
+                  (condition-case nil
+                      (progn (up-list -1)
+                             (point))
+                    (error nil)))))
       (condition-case nil
 	  (if beg
 	      (progn (forward-sexp)

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Glenn Morris]

Andreas Röhler wrote:

> patch attached

Please, nobody apply this patch (preferably, don't even reference it),
since the author has issues with copyright assignment.
That's his prerogative of course, but as has been pointed out in the
past it makes it impossible for us to use any patches.

Please let's NOT have yet another discussion of those assignment issues
here, I'm just pointing out facts, not making any judgements.

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Andreas Röhler]

Am 14.03.2013 16:59, schrieb Glenn Morris:
> Andreas Röhler wrote:
>
>> patch attached
>
> Please, nobody apply this patch (preferably, don't even reference it),
> since the author has issues with copyright assignment.
> That's his prerogative of course, but as has been pointed out in the
> past it makes it impossible for us to use any patches.
>
> Please let's NOT have yet another discussion of those assignment issues
> here, I'm just pointing out facts, not making any judgements.
>
>
>
>

http://www.gnu.org/software/libtool/contribute.html:

"Individual small changes (fewer than 10 lines of code) can, however, be accepted
without a copyright assignment form on file. "

Added four lines of code.

As for the assignment mentioned, it stipulates for example:

"I hereby indemnify and hold harmless the Foundation, its
officers, employees, and agents against any and all claims,
actions or damages (including attorney's reasonable fees)
asserted by or paid to any party on account of a breach or
alleged breach of the foregoing warranty."

Where the "alleged breach" is the point.
So you indemnify also if being falsely brought to court?
Alleged is enough?

Wondering, how reasonable people may sign such a contract.

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Stefan Monnier]

Let's stick to the ffap bug here, and leave debates about copyright
assignments elsewhere (ideally not emacs-devel either).


        Stefan

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Andreas Röhler]

Am 15.03.2013 14:09, schrieb Stefan Monnier:
> Let's stick to the ffap bug here, and leave debates about copyright
> assignments elsewhere (ideally not emacs-devel either).
>
>
>          Stefan
>

Didn't introduce that matter here.

As for the trivial patch, you will find a way to fix it with an alternative triviality,
  should my decent piece not being accepted.

BTW there are some more issues around, this might the most crucial one wrt to results, as it will no longer break
  when called from inside a string.

Regards,

Andreas

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Nicolas Petton]

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> As for the trivial patch, you will find a way to fix it with an alternative triviality,
>  should my decent piece not being accepted.

I cannot reproduce the issue on master today, should I close this
ticket?

Cheers,
Nico

bug#13955: Subject: 24.3; (thing-at-point 'list) fails

[Noam Postavsky]

close 13955 26.1
unarchive 24627
merge 13955 24627
quit

Nicolas Petton <nicolas@petton.fr> writes:

> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> As for the trivial patch, you will find a way to fix it with an alternative triviality,
>>  should my decent piece not being accepted.
>
> I cannot reproduce the issue on master today, should I close this
> ticket?

Yes, it's fixed in 26.1.  See also Bug#31772 for discussion over the new
behaviour.