From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Wed, 20 Jun 2018 19:28:32 -0400 Message-ID: <87602drqan.fsf@gmail.com> References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529537630 25373 195.159.176.226 (20 Jun 2018 23:33:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2018 23:33:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 30190@debbugs.gnu.org, tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 21 01:33:45 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVmbd-0006RU-K6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 01:33:41 +0200 Original-Received: from localhost ([::1]:52190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVmdk-0006bS-O8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 19:35:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVmXB-0001aM-87 for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 19:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVmX8-0007CH-5v for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 19:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50168) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVmX8-0007C7-1s for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 19:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVmX7-0007IS-Ip for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 19:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jun 2018 23:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152953732127984 (code B ref 30190); Wed, 20 Jun 2018 23:29:01 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 20 Jun 2018 23:28:41 +0000 Original-Received: from localhost ([127.0.0.1]:58065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVmWn-0007HI-3x for submit@debbugs.gnu.org; Wed, 20 Jun 2018 19:28:41 -0400 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:55831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVmWm-0007H3-6K for 30190@debbugs.gnu.org; Wed, 20 Jun 2018 19:28:40 -0400 Original-Received: by mail-it0-f50.google.com with SMTP id 16-v6so2056392itl.5 for <30190@debbugs.gnu.org>; Wed, 20 Jun 2018 16:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bJbu10QcB1j/2BZlJZnGnIkMLAw3P4Yvqj21e3AtiTA=; b=afXa/1nRsMuOXvKm+N2iEwhKYRqQ8xQcEzriYExsKsJQsOCdWeKf5XHc7AOxOhJeaR UQ/oTYA/ogPEai/fB9kPxmotoT5mUJz+jJmph/YRRDEklUwBKX6OoAhhKXs1/MrroCmN hGySgv7+g+F2knvsO2NNKdVGhAcY94kGOJtvYltAB+5yMWlaJyZ4V/PC3g3rMWwx3OVT VLpCMyrf+B17fqEpWg4WpAB3NUUr29VFAwYaKaea83cshtiYGjZmoL38x6vVnra12FZf MUH+XZoJMXEOu4sAvWYhZu/vZ8gehERQQhP7IpaJp/oribtlMFH1HyVw4ZwVCyUIzSWI Cd4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bJbu10QcB1j/2BZlJZnGnIkMLAw3P4Yvqj21e3AtiTA=; b=WQHMsYeG1s+lg/SOnI+8vH0YjxVmqput8n+lzX9bLsyVTKWM3nLwAXTr8kR1GFLejG YHQCBuhBWrfJEnwA7q3DkNV85ad8yN6XEehDrcAef04PI2RW+UNWktxDp5YHRv8g15Ex jC32Y+2mVHoB8C4t4qFBn10iJDCTOT8NT6Lz42sIqtvqodtAm5hupJBgCdpcMX8PRzET 9n5lRXuEI+SXJOnmkz117JI9nzWP1/jnX2TK/sfwtwGEiKkjBebsMJGeXm4nxk6h0ebz 0DStlyDiNJzXUexd5gxVihWxr8Yf1nAxdug5RuN7f2zKwzmqFPFmzvHbprPUBU2cbpPw 9eUQ== X-Gm-Message-State: APt69E0ez181xXxlk16ur8DH6+AiJUsFkrvLn04Cu5TGIgIrBXHp93/9 GhWlX65GI1tp5pb4zY/hjAc= X-Google-Smtp-Source: AAOMgpe136xH1R9kei6CqYQ/musa6r+U3zEFdo8yu/B4pmanYSKikoT8dZHXYE5l8//+fbCK31vYYw== X-Received: by 2002:a24:efc2:: with SMTP id i185-v6mr3131088ith.57.1529537314550; Wed, 20 Jun 2018 16:28:34 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y36-v6sm2016884ita.4.2018.06.20.16.28.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jun 2018 16:28:33 -0700 (PDT) In-Reply-To: <83efh1s9s3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Jun 2018 19:27:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147676 Archived-At: Eli Zaretskii writes: > I'm for fixing this in Emacs 26.2, but I still don't think I > understand why the latest patch proposed in the discussion of this bug > needs to "steal" so much from comint.el? > > Also, why does term-watch-for-password-prompt need to be invoked via a > hook? I don't these things are really required; as far as I understand, Tino did it that way in order to be safer: the "stealing" is to avoid loading comint.el, and using the hook is to keep the code closer to the already working example it's being copied from.